Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secops structure code #24652

Merged
merged 9 commits into from
Oct 26, 2018
Merged

Secops structure code #24652

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
172c914
add basic structure for secops application
XavierM Oct 25, 2018
7e27819
finalize skeleton for secops
XavierM Oct 26, 2018
885b80f
fix type issue and hapi new version
XavierM Oct 26, 2018
f4937fc
remove route home, not needed for now
XavierM Oct 26, 2018
9482792
Add configuration + delete noise
XavierM Oct 26, 2018
0fc01af
prepend elastic license to generated file
XavierM Oct 26, 2018
f436513
wip review
XavierM Oct 26, 2018
412d03b
wip review
XavierM Oct 26, 2018
86a100c
wip review fix miss spelling + add a new line between elastic license…
XavierM Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@
/.env
/.kibana-plugin-helpers.dev.*
!/plugins/infra/**/target
!/plugins/secops/**/target
2 changes: 2 additions & 0 deletions x-pack/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import { kueryAutocomplete } from './plugins/kuery_autocomplete';
import { canvas } from './plugins/canvas';
import { infra } from './plugins/infra';
import { rollup } from './plugins/rollup';
import { secops } from './plugins/secops';

module.exports = function (kibana) {
return [
Expand Down Expand Up @@ -55,5 +56,6 @@ module.exports = function (kibana) {
kueryAutocomplete(kibana),
infra(kibana),
rollup(kibana),
secops(kibana),
];
};
1 change: 1 addition & 0 deletions x-pack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
"@types/react-dom": "^16.0.5",
"@types/react-redux": "^6.0.6",
"@types/react-router-dom": "^4.3.1",
"@types/recompose": "^0.26.0",
Copy link
Contributor

@FrankHassanabad FrankHassanabad Oct 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not with this PR, but sometime soon we should probably figure out the cadence schedule of package updates since recompose is at 0.30.0 and they just updated hapi.js and we're still sitting at 0.26.0 with recompose. Would be nice to get this to the latest before using too much of its features.

Newer recompose looks like 0.30.0:
https://github.com/acdlite/recompose/releases

Wrote an issue for it https://github.com/elastic/ingest-dev/issues/67

"@types/reduce-reducers": "^0.1.3",
"@types/sinon": "^5.0.1",
"@types/supertest": "^2.0.5",
Expand Down
Loading