Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] [beats/heartbeat] Fix heartbeat add data instructions (#24795) #24813

Merged
merged 1 commit into from
Oct 30, 2018
Merged

[6.x] [beats/heartbeat] Fix heartbeat add data instructions (#24795) #24813

merged 1 commit into from
Oct 30, 2018

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Oct 30, 2018

Backports the following commits to 6.x:

@andrewvc @ruflin
[beats/heartbeat] Fix heartbeat add data instructions (elastic#24795)
71b3feb 
This commit does three things:
0. This fixes the instructions for interacting with the heartbeat service, which is called `heartbeat-elastic` not `heartbeat`
1. This removes some extraneous text that should be reserved for the subsequent section.
2. This makes the instructions for creating a monitor more explicit
@ruflin ruflin requested a review from andrewvc October 30, 2018 08:11
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

andrewvc
andrewvc approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc andrewvc merged commit 23d89c8 into elastic:6.x Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruflin @elasticmachine @andrewvc