[i18n] Translate Security -> Account and Nav control components #26011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibmt
requested review from
pavel06081991 and
maryia-lapata
and removed request for
maryia-lapata
pavel06081991
approved these changes
Nov 22, 2018
x-pack/plugins/security/public/views/nav_control/nav_control_component.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/security/public/views/nav_control/nav_control_component.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/security/public/views/nav_control/nav_control.html
Outdated
Show resolved
Hide resolved
💔 Build Failed |
joshdover
suggested changes
Nov 30, 2018
...ment/edit_role/components/privileges/kibana/__snapshots__/privilege_space_form.test.tsx.snap
Outdated
Show resolved
Hide resolved
…/kibana into feature/translations/login
maryia-lapata
changed the title
| @@ -10,7 +10,7 @@ | |||
| <global-nav-link | |||
| kbn-route="'/logout'" | |||
| icon="'plugins/security/images/logout.svg'" | |||
| tooltip-content="formatTooltip('Logout')" | |||
| label="'Logout'" | |||
| tooltip-content="formatTooltip(logoutLabel)" | |||
There was a problem hiding this comment.
@joshdover I added localization for tooltip as well, but I didn't find formatTooltip function. I think it should be similar to accountTooltip https://github.com/elastic/kibana/pull/26011/files#diff-02abf9793c68e526c53c333ee2301584R41
Is this issue known?
There was a problem hiding this comment.
Yeah I'm not seeing that function anywhere either. I agree it seems like it should just be accountTooltip
There was a problem hiding this comment.
@joshdover, don't you mind if I just replace formatTooltip with accountTooltip in this PR?
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Dec 5, 2018
…tic#26011) * translate login/logout visualization component * Update login/logout component - change injecti18n name to injectI18n * Update login/logout component - make needed changes * update one snapshot * update login translation * update one snapshot * Fix * Fix unit test * Localize logout tooltip
maryia-lapata
added a commit
that referenced
this pull request
Dec 5, 2018
…) (#26689) * translate login/logout visualization component * Update login/logout component - change injecti18n name to injectI18n * Update login/logout component - make needed changes * update one snapshot * update login translation * update one snapshot * Fix * Fix unit test * Localize logout tooltip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translate login/logout visualization component