Add rest_total_hits_as_int into kibana platform #26432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Team:Core
|
Pinging @elastic/kibana-platform |
💔 Build Failed |
|
Jenkins, test this - Change should now be on master snapshot |
💔 Build Failed |
💔 Build Failed |
mikecote
force-pushed
the
rest_total_hits_as_int
branch
from
a8d13c4
to
cdf938e
Compare
💔 Build Failed |
mikecote
force-pushed
the
rest_total_hits_as_int
branch
from
cdf938e
to
0d6b651
Compare
💚 Build Succeeded |
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Dec 4, 2018
* Add rest_total_hits_as_int into Kibana platform * Add missing returns statement in repository.test.js
timroes
added a commit
that referenced
this pull request
Dec 4, 2018
mikecote
added
the
non-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements Step 1 of #26356.
This will add
rest_total_hits_as_int: trueto all requests in platform code that eventually looks uphits.total. The changes are in the following areas:This PR will need to run against a new snapshot of elasticsearch that contains elastic/elasticsearch#36051 before tests start to pass and a review gets requested.
Checklist
[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately