Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rollups] Require histogram interval in Rollup Job wizard to be a whole number. #26596

Merged
merged 1 commit into from
Dec 4, 2018
Merged

[Rollups] Require histogram interval in Rollup Job wizard to be a whole number. #26596

merged 1 commit into from
Dec 4, 2018

Conversation

cjcenizal
Copy link
Contributor

Fixes #26548

image

@cjcenizal cjcenizal added v7.0.0 v6.6.0 es-management Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Dec 4, 2018
@cjcenizal cjcenizal requested a review from bmcconaghy December 4, 2018 00:26
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

bmcconaghy
bmcconaghy approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@cjcenizal cjcenizal merged commit ef77982 into elastic:master Dec 4, 2018
@cjcenizal cjcenizal deleted the rollups/whole-number-validation branch December 4, 2018 20:20
@cjcenizal cjcenizal mentioned this pull request Dec 4, 2018
Merged
cjcenizal added a commit that referenced this pull request Dec 4, 2018
@cjcenizal
Require histogram interval in Rollup Job wizard to be a whole number. (…
1ab8e14 
…#26596) (#26657)
@cjcenizal cjcenizal mentioned this pull request Dec 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcconaghy bmcconaghy bmcconaghy approved these changes

Assignees
No one assigned
Labels
Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v6.6.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjcenizal @elasticmachine @bmcconaghy