Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate dep, x-pack/yarn.lock #26642

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

joshdover
Copy link
Contributor

Summary

  • Removes the duplicate datemath dependency
  • Removes x-pack/yarn.lock that keeps coming back
  • Added x-pack/yarn.lock to gitignore

@joshdover joshdover requested a review from spalger December 4, 2018 17:14
@joshdover joshdover added Team:Operations Team label for Operations Team v7.0.0 v6.6.0 labels Dec 4, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joshdover joshdover merged commit a7e6875 into elastic:master Dec 4, 2018
@joshdover joshdover deleted the fx-xpack-deps branch December 4, 2018 18:04
joshdover added a commit that referenced this pull request Dec 5, 2018
* Remove duplicate dep, x-pack/yarn.lock (#26642)

* [npm] prepare @kbn/datemath for publishing (#26559)

We need to share `@kbn/datemath` with `@elastic/eui`, and rather than making them rely on Kibana for their dependencies we've decided to republish `@kbn/datemath` as `@elastic/datemath`. This isn't something we want to do often, so please check with the platform team if you'd like to do this for another module.
@joshdover
Copy link
Contributor Author

6.x: 4cd2360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants