-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript visualize_embeddable file #26660
Merged
stacey-gammon
merged 2 commits into
elastic:master
from
stacey-gammon:2018-12-04-typescript-vis-embed
Dec 5, 2018
Merged
Typescript visualize_embeddable file #26660
stacey-gammon
merged 2 commits into
elastic:master
from
stacey-gammon:2018-12-04-typescript-vis-embed
Dec 5, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build triggered but pending for 7 hours 🤔 jenkins, test this |
💔 Build Failed |
stacey-gammon
force-pushed
the
2018-12-04-typescript-vis-embed
branch
from
December 5, 2018 03:38
7f27111
to
a32cd25
Compare
💚 Build Succeeded |
stacey-gammon
added
chore
v7.0.0
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v6.6.0
labels
Dec 5, 2018
Pinging @elastic/kibana-app |
timroes
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me
timroes
reviewed
Dec 5, 2018
src/legacy/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Dec 5, 2018
* Typescript visualize_embeddable file * Remove left over comment
stacey-gammon
added a commit
that referenced
this pull request
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Typescriptify visualize_embeddable file.