Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript visualize_embeddable file #26660

Merged

Conversation

stacey-gammon
Copy link
Contributor

Summary

Typescriptify visualize_embeddable file.

@stacey-gammon
Copy link
Contributor Author

build triggered but pending for 7 hours 🤔

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon stacey-gammon force-pushed the 2018-12-04-typescript-vis-embed branch from 7f27111 to a32cd25 Compare December 5, 2018 03:38
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stacey-gammon stacey-gammon added chore v7.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0 labels Dec 5, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stacey-gammon stacey-gammon merged commit 108d77d into elastic:master Dec 5, 2018
stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Dec 5, 2018
* Typescript visualize_embeddable file

* Remove left over comment
stacey-gammon added a commit that referenced this pull request Dec 6, 2018
* Typescript visualize_embeddable file

* Remove left over comment
@stacey-gammon stacey-gammon deleted the 2018-12-04-typescript-vis-embed branch December 6, 2018 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants