Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@elastic/datemath] add .npmignore file #26664

Merged
merged 3 commits into from
Dec 4, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Dec 4, 2018

With #26559 we made @elastic/datemath a publishable package, but we didn't include a .npmignore file so things like the tsconfig.json file are included, which includes relative paths that reach out of the package. In order to avoid that we should use a .npmignore file that strips out any unnecessary file from the package.

@spalger spalger added review Team:Operations Team label for Operations Team v7.0.0 labels Dec 4, 2018
@spalger spalger requested a review from jbudz December 4, 2018 21:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit a64afc0 into elastic:master Dec 4, 2018
@spalger spalger deleted the fix/elastic-datemath/npmignore branch December 4, 2018 23:28
@spalger
Copy link
Contributor Author

spalger commented Dec 4, 2018

Published @elastic/datemath@5.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Operations Team label for Operations Team v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants