Switch implicit server.log behavior with tmpl to logWithMetadata #29002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
spalger
approved these changes
Jan 22, 2019
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Jan 23, 2019
…stic#29002) * Changing the optimizer's use to logWithMetadata * Switching ensureEsVersion to logWithMetadata * Changing pid logging to use logWithMetadata * Changing server/plugins to use logWithMetadata * Changing saved objects onBeforeWrite to logWithMetata * Changing server/status to server.logWithMetadata * Changing ui settings to use logWithMetadata * Removing _.template's usage from within log_format * Fixing initializing plugin log message * Fixing ensureEsVersion tests * Fixing health check tests * Fixing a few more forgotten tests
kobelb
added a commit
that referenced
this pull request
Jan 23, 2019
) (#29182) * Changing the optimizer's use to logWithMetadata * Switching ensureEsVersion to logWithMetadata * Changing pid logging to use logWithMetadata * Changing server/plugins to use logWithMetadata * Changing saved objects onBeforeWrite to logWithMetata * Changing server/status to server.logWithMetadata * Changing ui settings to use logWithMetadata * Removing _.template's usage from within log_format * Fixing initializing plugin log message * Fixing ensureEsVersion tests * Fixing health check tests * Fixing a few more forgotten tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the existing usages of of server.log's implicit behavior when it finds a plain object with a tmpl to use an explicit method where you can pass a message and metadata.
logWithMetadatamore closely mirrors what we'll be doing in the new platform, and prevents people from accidentally tripping on the implicit behavior.