[home/sampleData] add empty migrationVersion to auto-migration objects #29226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
v7.0.0
Feature:Home
|
Pinging @elastic/kibana-app |
|
What about Sample data saved objects from Canvas and GIS? Should those be updated as well? https://github.com/elastic/kibana/blob/master/x-pack/plugins/canvas/init.js#L10 https://github.com/elastic/kibana/blob/master/x-pack/plugins/gis/index.js#L63 |
nreese
approved these changes
Jan 24, 2019
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jan 24, 2019
elastic#29226) The sample data does not currently specify a migration version, which means we have manually update the data sets when updating the saved objects API. This just sets the migration version for all the saved objects to `{}`, which signals to the saved objects API that the object has not been migrated and should have all migrations applied.
💚 Build Succeeded |
spalger
pushed a commit
that referenced
this pull request
Jan 24, 2019
#29226) (#29230) The sample data does not currently specify a migration version, which means we have manually update the data sets when updating the saved objects API. This just sets the migration version for all the saved objects to `{}`, which signals to the saved objects API that the object has not been migrated and should have all migrations applied.
|
6.x/6.7: 173dadc |
|
FWIW, I did try this in Canvas, and all the sample workpads worked fine. I also tried it with an existing instance, and everything worked as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample data does not currently specify a migration version, which means we have manually update the data sets when updating the saved objects API. This just sets the migration version for all the saved objects to
{}, which signals to the saved objects API that the object has not been migrated and should have all migrations applied.