[ML] Fixing overflowing metric values in field cards #29255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
bug
jgowdyelastic
requested review from
walterra,
alvarezmelissa87 and
peteharverson
walterra
reviewed
Jan 24, 2019
x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js
Outdated
Show resolved
Hide resolved
walterra
approved these changes
Jan 24, 2019
💔 Build Failed |
💔 Build Failed |
|
retest |
💔 Build Failed |
|
retest |
💔 Build Failed |
|
retest |
jgowdyelastic
force-pushed
the
rounding-field-stats-to-fix-overflow
branch
from
4e566bf to
d680de1
Compare
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jan 24, 2019
* [ML] Fixing overflowing metric values in field cards * adding better rounding for tiny numbers * removing debug line
jgowdyelastic
added a commit
that referenced
this pull request
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round min, max and median values to 2dp to fix occasional overflow.
Before:
After:
For very small numbers which would normally round to
0, a new function converts them to index notation.e.g.
-0.000000234is converted to-2.34e-7Adds a new formatter function to do the rounding along with some tests.
Fixes #28567