-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Removes problematic float #29875
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
Team:Docs
v7.0.0
Feature:Kibana Management
Feature label for Data Views, Advanced Setting, Saved Object management pages
labels
Feb 1, 2019
schersh
approved these changes
Feb 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built locally, LGTM
💔 Build Failed |
lcawl
added a commit
that referenced
this pull request
Feb 1, 2019
lcawl
added a commit
that referenced
this pull request
Feb 1, 2019
lcawl
added a commit
that referenced
this pull request
Feb 1, 2019
lcawl
added a commit
that referenced
this pull request
Feb 1, 2019
lcawl
added a commit
that referenced
this pull request
Feb 1, 2019
lcawl
added a commit
that referenced
this pull request
Feb 1, 2019
lcawl
added a commit
that referenced
this pull request
Feb 1, 2019
lcawl
added a commit
that referenced
this pull request
Feb 1, 2019
lcawl
added a commit
that referenced
this pull request
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When I try to build the Kibana Guide via "docbldkb --asciidoctor --lenient", it fails as follows:
The float in that file seems unnecessary, so this PR removes it.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[skip ci]