Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas][Layout Engine][WIP][skip ci] Refactor: Rework of Layout Engine state #30827

Closed
wants to merge 34 commits into from
Closed

[Canvas][Layout Engine][WIP][skip ci] Refactor: Rework of Layout Engine state #30827

wants to merge 34 commits into from

Conversation

monfera
Copy link
Contributor

@monfera monfera commented Feb 12, 2019 •
edited
Loading

WIP branch for simplifying the Layout Engine state integration with the global Canvas Redux state

@monfera monfera added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Feb 12, 2019
@monfera monfera self-assigned this Feb 12, 2019
@monfera monfera requested review from a team as code owners February 12, 2019 13:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@monfera monfera force-pushed the layout-usability-improvements-3 branch from be44edc to 74c8e89 Compare February 13, 2019 10:07
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@monfera monfera force-pushed the layout-usability-improvements-3 branch from 8aaa4d7 to ef748d0 Compare February 14, 2019 09:08
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ryankeairns ryankeairns mentioned this pull request Feb 14, 2019
Closed
44 tasks
monfera added 13 commits February 14, 2019 23:47
@monfera
Feat: box select
a5bd26b
@monfera
minor
33264e1
@monfera
Refactor: preserve gesture state in favor of local selectReduce 1
6664015
@monfera
Refactor: preserve gesture state in favor of local selectReduce 2 (ju…
8b9b026 
…st lines rearrangement)
@monfera
Refactor: preserve gesture state in favor of local selectReduce 3
d1f6745
@monfera
Refactor: preserve gesture state in favor of local selectReduce 4 - c…
3fb4400 
…ontroversial simplification!
@monfera
Refactor: preserve gesture state in favor of local selectReduce 5
3a00242
@monfera
Refactor: preserve gesture state in favor of local selectReduce 6
18c4ceb
@monfera
Refactor: nicer, simpler shallowEqual (potentially marginally slower)
5ebb5b8
@monfera
Chore: remove disused dispatch
7469813
@monfera
Fix: No longer break the user session upon encountering some race con…
cc9d154 
…dition that doesn't impede layout management anyway
@monfera
Chore: shapeAdditions disused; cleaning up state.ts
6c7eeec
@monfera
Refactor: configuration is normal part of the scene
7fa8a1b
@monfera monfera force-pushed the layout-usability-improvements-3 branch from a63c40d to 7fa8a1b Compare February 14, 2019 22:47
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@monfera monfera changed the title [Canvas][Layout Engine][WIP] Feat: box select [Canvas][Layout Engine][WIP][skip ci] Feat: box select Feb 15, 2019
@monfera monfera force-pushed the layout-usability-improvements-3 branch from 8d0ebbb to 26d878c Compare February 15, 2019 11:24
@monfera monfera force-pushed the layout-usability-improvements-3 branch from 785802f to c1b26c1 Compare February 17, 2019 19:42
@monfera monfera force-pushed the layout-usability-improvements-3 branch from 4a5ac0c to 9f3d656 Compare February 18, 2019 09:26
@monfera monfera mentioned this pull request Feb 25, 2019
Closed
@monfera monfera changed the title [Canvas][Layout Engine][WIP][skip ci] Feat: box select [Canvas][Layout Engine][WIP][skip ci] Refactor: Rework of Layout Engine state Mar 12, 2019
@monfera
Copy link
Contributor Author

monfera commented Apr 16, 2019

Closing this WIP PR as it got superseded by #33702 that's been merged.

@monfera monfera closed this Apr 16, 2019
@spalger spalger deleted the layout-usability-improvements-3 branch November 8, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@monfera monfera

Labels
Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monfera @elasticmachine