Render Zero Values in Percent Charts Properly #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fix_tooltip Conflicts: src/kibana/components/vislib/lib/dispatch.js
This was referenced Feb 19, 2015
Closed
|
This LGTM but doesn't cleanly backport on the 4.0 branch. Can you backport it and apply it to both master and 4.0? edit: nevermind, done |
rashidkpc
added a commit
that referenced
this pull request
Feb 23, 2015
Render Zero Values in Percent Charts Properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues found in #1659 (see comments at bottom), #3083 and #3093.
In
percentmode, vertical bar charts render bars when all values in a stack are zero. For example, if we have 3 values of 0 in a stack, then each value is given a proportion of 0.33. This behavior is undesirable, and so we have added a conditional statement that returns a zero value for the bar height in these situations.In the pr is also a fix for displaying the percent values in the tooltip along with the count value. This was removed previously and is getting put back in.