Allow time ranges before the epoch in discover #31807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
changed the title
💔 Build Failed |
flash1293
changed the title
|
The rewrite of the filter format has to be moved to createFilter in the timefilter because various places rely on gte and lte to be numbers for comparison. |
💔 Build Failed |
flash1293
force-pushed
the
30420/fix-timepicker-before-epoch
branch
from
3521de9
to
d33ed7a
Compare
💚 Build Succeeded |
💔 Build Failed |
flash1293
force-pushed
the
30420/fix-timepicker-before-epoch
branch
from
8993b6a
to
accd9af
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
flash1293
changed the title
lukasolson
approved these changes
Mar 1, 2019
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Mar 4, 2019
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Mar 4, 2019
flash1293
added a commit
that referenced
this pull request
Mar 5, 2019
flash1293
added a commit
that referenced
this pull request
Mar 5, 2019
timroes
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #30420
Switches the time range query to strict_date_optional_time to allow for values before the epoch.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately