Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] i18n asciidocs #32547

Merged
merged 12 commits into from
Apr 3, 2019
Merged

[Docs] i18n asciidocs #32547

merged 12 commits into from
Apr 3, 2019

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Mar 6, 2019 •
edited
Loading

Context: #22349

  • tell about locale
  • describe how to set a locale
  • describe how developers can use i18n engine functionality

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@Bamieh Bamieh changed the base branch from master to 6.7 March 6, 2019 12:58
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexfrancoeur
Copy link

@Bamieh is there any update here? We're trying to determine if we can link out to docs from the press release / release blog. If not, that's fine, we just need to know in order to prepare the web content.

@Bamieh Bamieh marked this pull request as ready for review March 26, 2019 13:24
@elasticmachine
Copy link
Contributor

💔 Build Failed

@Bamieh Bamieh requested a review from gchaps March 26, 2019 17:20
@Bamieh
Copy link
Member Author

Bamieh commented Mar 26, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

alexfrancoeur
alexfrancoeur approved these changes Mar 26, 2019
View reviewed changes
Copy link

@alexfrancoeur alexfrancoeur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just read through, LGTM. Think this is something we can get in soon? 6.7 is today, I imagine our users will be looking for docs on not only how to enable a translation but eventually translate themselves.

gchaps
gchaps reviewed Mar 26, 2019
View reviewed changes
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
azasypkin
azasypkin reviewed Mar 27, 2019
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ to all suggestions from Gail and a couple of nits. Please unify and fix all links. The rest LGTM from the technical perspective.

Is there any reason why we're targeting this only against 6.7? I guess PR should target master and be backported to every possible branch once it's merged (6.7/7.0/7.x).

Thanks!

docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
@gchaps @Bamieh
Apply suggestions from code review
e9f3629 
Gail review

Co-Authored-By: Bamieh <ahmadbamieh@gmail.com>
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Bamieh Bamieh requested a review from jinmu03 March 27, 2019 15:34
@Bamieh Bamieh requested review from azasypkin and removed request for azasypkin March 31, 2019 12:56
@Bamieh Bamieh requested review from gchaps and azasypkin March 31, 2019 12:56
@Bamieh Bamieh changed the base branch from 6.7 to master March 31, 2019 13:13
@Bamieh Bamieh changed the base branch from master to 6.7 March 31, 2019 13:16
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

schersh
schersh approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@schersh schersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one comment

docs/settings/i18n-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/i18n-settings.asciidoc Outdated Show resolved Hide resolved
docs/settings/i18n-settings.asciidoc Outdated Show resolved Hide resolved
gchaps
gchaps approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few minor formatting changes

docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
docs/development/plugin/development-plugin-localization.asciidoc Outdated Show resolved Hide resolved
gchaps and others added 2 commits April 3, 2019 19:55
@gchaps @Bamieh
Update docs/development/plugin/development-plugin-localization.asciidoc
a5a7f0f 
Co-Authored-By: Bamieh <ahmadbamieh@gmail.com>
@Bamieh
Apply suggestions from code review
4e32345 
Co-Authored-By: Bamieh <ahmadbamieh@gmail.com>
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Bamieh Bamieh merged commit b871926 into elastic:6.7 Apr 3, 2019
@Bamieh Bamieh deleted the 6.7-i18n-docs branch April 3, 2019 15:27
@schersh schersh mentioned this pull request Apr 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schersh schersh schersh approved these changes

@alexfrancoeur alexfrancoeur alexfrancoeur approved these changes

@gchaps gchaps gchaps approved these changes

@jinmu03 jinmu03 Awaiting requested review from jinmu03

@azasypkin azasypkin Awaiting requested review from azasypkin

Assignees
No one assigned
Labels
Project:i18n Team:Docs v6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Bamieh @elasticmachine @alexfrancoeur @azasypkin @schersh @gchaps