Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Feat: Box select #32995

Merged
merged 4 commits into from
Jun 28, 2019
Merged

[Canvas] Feat: Box select #32995

merged 4 commits into from
Jun 28, 2019

Conversation

monfera
Copy link
Contributor

@monfera monfera commented Mar 12, 2019 •
edited
Loading

Closes #30841

boxselect

Solves item 3 of #29190
Partial mitigation for #23226
Was blocked by #33702

@monfera monfera self-assigned this Mar 12, 2019
@monfera monfera requested review from a team as code owners March 12, 2019 13:07
@monfera monfera mentioned this pull request Mar 31, 2019
Merged
12 tasks
@monfera monfera changed the title [Canvas][WIP][skip ci] Feat: Box select [Canvas][WIP] Feat: Box select Apr 13, 2019
@elastic elastic deleted a comment from elasticmachine Apr 14, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ryankeairns
Copy link
Contributor

@monfera is this ready for review?

@monfera
Copy link
Contributor Author

monfera commented Apr 17, 2019

@ryankeairns not yet, and it'll likely be finished after some other tasks ie. toward the end of April. I'm not planning a lot of changes, except tying loose ends and doing what had been discussed in the channel with Clint yesterday

@ryankeairns ryankeairns mentioned this pull request May 22, 2019
Closed
44 tasks
@monfera monfera added the review label Jun 25, 2019
@monfera
Copy link
Contributor Author

monfera commented Jun 25, 2019

whole box

Uploading box select.gif…

@monfera monfera added release_note:enhancement enhancement New value added to drive a business result v7.3.0 v7.4.0 labels Jun 25, 2019
@monfera monfera requested review from ryankeairns and cqliu1 June 25, 2019 13:00
@monfera monfera added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jun 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@elastic elastic deleted a comment from elasticmachine Jun 25, 2019
ryankeairns
ryankeairns reviewed Jun 25, 2019
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this PR, despite technical shortcomings noted by Robert, still provides good value.

The only quirky thing I noticed was that if I group a set of elements, then use the box select, it will ungroup the elements. Personally, having tried this PR locally, I would still likely be in favor of pushing this through and addressing feedback as it comes. If we could address the ungrouping issue, that would be best, but still not a showstopper in my opinion.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@monfera monfera changed the title [Canvas][WIP] Feat: Box select [Canvas] Feat: Box select Jun 27, 2019
@monfera monfera requested a review from ryankeairns June 27, 2019 21:33
@elastic elastic deleted a comment from elasticmachine Jun 27, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

ryankeairns
ryankeairns approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, the groups remains intact upon box select. Thanks Robert, this is fantastic!

clintandrewhall
clintandrewhall approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving to unblock; I've tested it quite a bit, as well.

@monfera monfera merged commit b71ab9d into master Jun 28, 2019
@monfera monfera deleted the box-select branch June 28, 2019 20:30
@monfera monfera mentioned this pull request Jun 28, 2019
Merged
monfera added a commit that referenced this pull request Jun 28, 2019
@monfera
[Canvas] Feat: Box select (#32995) (#39948)
80cac1b 
[Canvas] Box select
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintandrewhall clintandrewhall clintandrewhall approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

@cqliu1 cqliu1 Awaiting requested review from cqliu1

Assignees

@monfera monfera

Labels
enhancement New value added to drive a business result release_note:enhancement review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.3.0 v7.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Canvas] Box select for selecting multiple elements
4 participants
@monfera @elasticmachine @ryankeairns @clintandrewhall