New platform dropdown #33520
Merged
New platform dropdown #33520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Replaced the Vega and Dev Console help menus with an EUI version.
|
lizozom
added
Feature:New Platform
EUI
Team:Visualizations
|
Pinging @elastic/kibana-app |
lizozom
added
the
Team:Kibana Management
|
Pinging @elastic/es-ui |
💔 Build Failed |
💚 Build Succeeded |
|
If I open a context menu and then click on another request that context menu stays open but is disembodied: |
bmcconaghy
suggested changes
Mar 19, 2019
src/legacy/core_plugins/console/public/src/controllers/sense_controller.js
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/console/public/src/directives/console_menu_directive.js
Outdated
Show resolved
Hide resolved
|
@bmcconaghy Can't reproduce this locally. |
💔 Build Failed |
|
@lizozom yup that was what I did. I'm on Chrome on Mac. |
peteharverson
approved these changes
Mar 20, 2019
💚 Build Succeeded |
bmcconaghy
approved these changes
Mar 21, 2019
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Mar 21, 2019
* Removed old dropdown code from dev tools consle * Removed old dropdown from vega tools * Deleted dropdown directives from angular bootstrap * Deleted ui.bootstrap.dropdown test (irrelevant, since directive was deleted)
lizozom
added a commit
that referenced
this pull request
Mar 21, 2019
94 tasks
cjcenizal
added
the
non-issue
|
Pinging @elastic/eui-design (EUI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed the directives
Switched the following to use EUI dropdown
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility