-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] visdata interpreter function #33674
Conversation
type: 'datatable', | ||
rows: data.rows, | ||
columns: data.columns.map(column => ({ | ||
name: column.id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to pass title as well ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the column
object looks like here, but name should be the field name, not some unique identifier used by Kibana.
Also, don't forget to add the column type
here, and just use 'string'
if you can't detect that (but you should be able to based on the field mappings you have).
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
with move to using expressions in visualize this will become harder, |
💔 Build Failed |
Summary
POC for visdata interpreter function
visdata id="saved-vis-id"
it will return datatable, or throw error if saved visualization is not table based (markdown, vega, tsvb, timelion)
if visualization requires a time range prepend expression with
filters |
and add a time picker to workpad.currently it has no UI, but that would probably be easy for someone from canvas team to add (should show a dropdown or sth with all saved visualziations (or maybe even the ones that don't return datatable filtered out)
PS: changing the code to not set
tableOnly
totrue
and changing functions type torender
will make this render all the visualizations (also checks for data.rows should be removed)@lukeelmers this required few hacks to visualize loader:
all along the line of the new api that was discussed here: #25374
part of closing #23035
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers