Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Removes abbrevtitles from parts #34002

Merged
merged 3 commits into from
Mar 27, 2019
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Mar 27, 2019

Summary

This PR makes the changes necessary for the Kibana Guide to be built via asciidoctor (see elastic/docs#756).

It fixes the following build errors:

element partintro: validity error : Element partintro content does not follow the DTD... got (titleabbrev )

In particular, it removes abbreviated titles due to asciidoctor/asciidoctor#3132

@gchaps @schersh If you prefer to use the abbreviated title strings as the titles, that can be easily changed.

[skip ci]

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@schersh schersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this - LGTM

@lcawl lcawl merged commit d3e8ee3 into elastic:master Mar 27, 2019
@lcawl lcawl deleted the kibana-asciidoctor branch March 27, 2019 20:23
lcawl added a commit that referenced this pull request Mar 27, 2019
lcawl added a commit that referenced this pull request Mar 27, 2019
lcawl added a commit that referenced this pull request Mar 27, 2019
@lcawl lcawl added the v6.7.1 label Mar 27, 2019
lcawl added a commit that referenced this pull request Mar 27, 2019
@lcawl lcawl added the v6.6.3 label Mar 27, 2019
lcawl added a commit that referenced this pull request Mar 27, 2019
@lcawl lcawl added the v6.5.5 label Mar 27, 2019
lcawl added a commit that referenced this pull request Mar 27, 2019
@lcawl lcawl added the v6.4.4 label Mar 27, 2019
lcawl added a commit that referenced this pull request Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants