Remove parse_query from public/ui #34232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved fromQuery toQuery to query bar
94 tasks
💚 Build Succeeded |
lukeelmers
reviewed
Apr 2, 2019
There was a problem hiding this comment.
I see why you moved toUser and fromUser to query_bar -- it makes more sense for them to live there than in agg_types -- but I think if we do that, we should also pull their corresponding tests out of the parse_query suite so that they live next to the helpers in their new home.
💚 Build Succeeded |
lukeelmers
approved these changes
Apr 3, 2019
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Apr 4, 2019
* Moved parse_query directive to agg_types Moved fromQuery toQuery to query bar * moved user input tests away from angular -> query_bar
lizozom
added a commit
that referenced
this pull request
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility