[Graph] Fix default drilldown link on index pattern switch #34251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
flash1293
added
Feature:Graph
|
Pinging @elastic/kibana-app |
|
@markharwood What do you think about this? Would you say we can go with this solution for now? |
Thanks for the fix. Seems like a reasonable approach. |
💚 Build Succeeded |
|
@markharwood Could you approve the PR for merging? |
markharwood
reviewed
Apr 11, 2019
markharwood
approved these changes
Apr 11, 2019
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Apr 15, 2019
flash1293
added a commit
that referenced
this pull request
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Somehow fixes #18522 . The problem is that on selecting an index pattern a default drilldown template is created which contains the id of the selected index pattern. If the index pattern is switched afterwards, it is not updated.
This PR adds a flag
isDefaultto the auto-drilldown-template, which marks it to re-create it on index pattern switch. If the user edits the template, it is kept even when switching between index patterns. While it fixes the bug as long as the user didn't change anything, it might not always be the expected behavior (e.g. if the user just edits the icon of the drilldown).A cleaner behavior would be removing all of the templates on index pattern switch, however this could result in data loss for the unexpecting user.
Another possibility would be making the default drilldown link readonly and non-removable, but this changes the current behavior of the UI and takes control from the user which I try to avoid.
What do you think, @timroes ?
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers