Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] expand/collapse Layer TOC #34506

Merged
merged 7 commits into from
Apr 10, 2019
Merged

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Apr 3, 2019

fixes #28029

Adds hide button to the Layer TOC that when clicked, minimizes the layer TOC.

Screen Shot 2019-04-09 at 11 56 59 AM

@nreese nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.2.0 labels Apr 3, 2019
@nreese nreese requested a review from a team as a code owner April 3, 2019 22:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@nreese
Copy link
Contributor Author

nreese commented Apr 3, 2019

@cchaos Can I get some help with the maximize button styling? It is terribly ugly now

Screen Shot 2019-04-03 at 4 45 32 PM

@nreese nreese mentioned this pull request Apr 3, 2019
10 tasks
@elasticmachine
Copy link
Contributor

💔 Build Failed

@cchaos
Copy link
Contributor

cchaos commented Apr 4, 2019

PR4U: nreese#30

@nreese nreese requested a review from thomasneirynck April 9, 2019 17:55
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as advertised, neat and clean improvement!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese nreese merged commit beea4ee into elastic:master Apr 10, 2019
nreese added a commit to nreese/kibana that referenced this pull request Apr 10, 2019
* [Maps] expand/collapse Layer TOC

* Design edits (#30)

* fix jest test snapshots

* make default isLayerTOCOpen a constant

* use newly release EUI menuLeft and menuRight icons instead of arrow icon
nreese added a commit that referenced this pull request Apr 10, 2019
* [Maps] expand/collapse Layer TOC

* Design edits (#30)

* fix jest test snapshots

* make default isLayerTOCOpen a constant

* use newly release EUI menuLeft and menuRight icons instead of arrow icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Ability to hide layer selection
4 participants