New platform cleanup filters #34555
Merged
New platform cleanup filters #34555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 tasks
💔 Build Failed |
💔 Build Failed |
added 2 commits
April 7, 2019 13:49
💚 Build Succeeded |
💔 Build Failed |
💚 Build Succeeded |
lizozom
requested review from
mattkime,
spalger and
a team
and removed request for
spalger
|
@elastic/kibana-platform please pay specific attention to the removal of the uriencode directive in src/legacy/ui/public/url/url.js |
mshustov
reviewed
Apr 8, 2019
💔 Build Failed |
|
retest |
💔 Build Failed |
|
retest |
lizozom
force-pushed
the
new-platform-cleanup-filters
branch
from
6de43c0 to
9501d3d
Compare
💚 Build Succeeded |
mattkime
approved these changes
Apr 10, 2019
💚 Build Succeeded |
eliperelman
reviewed
Apr 11, 2019
src/legacy/core_plugins/kibana/public/discover/controllers/discover.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/components/field_data_card/field_data_card_directive.js
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| return $parse(expr)(paramObj); | ||
| return encodeURIComponent($parse(expr)(paramObj)); |
There was a problem hiding this comment.
Can you explain why we always need to encode this?
There was a problem hiding this comment.
A. It's always best to encode URL params
B. It's the previous behavior :)
x-pack/plugins/ml/public/components/field_data_card/field_data_card_directive.js
Outdated
Show resolved
Hide resolved
added 2 commits
April 14, 2019 13:16
💚 Build Succeeded |
peteharverson
approved these changes
Apr 15, 2019
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Apr 15, 2019
* Delete label filter * Delete risonDecode * Deleted rison * removed fieldType filter * Deleted field type tests * Replaced uriescape filter with use of encodeURIComponent * Delete short dots filter * Removed usages of moment filter (and moved it to watcher) * Code review changes
lizozom
added a commit
that referenced
this pull request
Apr 15, 2019
* Delete label filter * Delete risonDecode * Deleted rison * removed fieldType filter * Deleted field type tests * Replaced uriescape filter with use of encodeURIComponent * Delete short dots filter * Removed usages of moment filter (and moved it to watcher) * Code review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removing filters from ui/filters
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility