Restore line rendering in point series vis using percentile agg

[kertal]

Summary

When creating a visualisation using percentiles, no lines were rendered.

Fix for #34858

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• [ ] This was checked for cross-browser compatibility, including a check against IE11
• [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• [ ] Documentation was added for features that require explanation or tutorials
• [ ] Unit or functional tests were updated or added to match the most common scenarios
• [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

• [ ] This was checked for breaking API changes and was labeled appropriately
• [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[markov00]

Tested locally seems to fix the missing line rendering problem.

Before merging I'd suggest to:

• find the root cause of the problem: seems that what changes is not now the seriid is composed (with the dot) but the way it's configured on the seriConfig.data.id; I'd suggest to investigate where we the original change, substituting the dot notation of the seriConfig.data.id to only the initial percentage id.
• if possible, try to add few tests to block any other possible changes of the seriId format for percentile aggregation

[kertal]

i took a closer look at it, this is a follow up problem of a refactoring, it's only relevant fo 7.x

the removal of aggId when building the series data obj

85bdd22#diff-0d98df44497e69dabf20a569326ad6caL31

This led to the following change:
85bdd22#diff-8363f944835538e447c3aedee84d3693L26

since there are composed ids for percentiles (1.5, 1.10, ...) this check didn't work anymore.

However, this can't be undone by adding aggId again, because the agg object is now longer available in this context

kibana/src/legacy/ui/public/agg_response/point_series/_add_to_siri.js

Line 20 in 2e232c2

export function addToSiri(series, point, id, yLabel, yFormat, zFormat, zLabel) {

also it's not available in the context of the functions call

https://github.com/elastic/kibana/blob/2e232c2e31cdc9ebcf1c75201571f82be003ea2d/src/legacy/ui/public/agg_response/point_series/_get_series.js

solving it in a different way needs to be discussed with @ppisljar, it's not a small refactoring.

[ppisljar]

code looks good,

• we have an aggregation that produces multiple responses. each aggConfig has an Id. in response we id the columns with that same id col-aggid and if agg returns multiple responses we name the culmns col-aggId.subId
• in editor we have a single configuration for all the responses agg produces (add percentile agg, go to metrics & axes tab and you will see there is a single series configuration.
• vis gets the data in and processes it a bit (extracts the ids out of column ids for example)
• later it tries to match series configurations to appropriate data series
• as we have one config for all columns produced by one aggregation, we need to make sure matching works correctly

we could have this more explicit and have an option to provide multiple column ids for every serie config, or have duplicated series configurations for each of the columns, but i think this fix is fine for now, specially as we are looking to retire vislib in the long run.

@kertal can you please add a test for this ?

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[ppisljar]

LGTM, tested on chrome linux