Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link search feature #361

Closed
wants to merge 3 commits into from
Closed

Add link search feature #361

wants to merge 3 commits into from

Conversation

frankyaorenjie
Copy link

With this feature, users can specify search pattern in URL like this http://kibana.com/logstash.json?query="defg". And Kibana will automatically search this pattern.
screenshot from 2013-08-14 12 21 07

@rashidkpc
Copy link
Contributor

I like where this is going. I'd like to see it refined in the following ways:

  1. Able to handles multiple queries. We need to consider what happens when queries are already present. Should we add to them? Replace them?
  2. Able to assign an alias, maybe the type as well. Perhaps it could be generalized to handle all of the properties of the query object? Should probably use the set() function here.

@frankyaorenjie
Copy link
Author

Hi rashidkpc,

  1. use specified separator to split multiple queries. I think this feature is used while someone click this url and jump to a new web page, so why there are queries which are already present?
  2. I don't think make alias or type a param which can be defined in url params is a good choice. In my opinion, these are so-called configuration params in kibana, not user-customized params that can be different between uses. Also, since kibana3 has a high-customized dashboard, is it possible to handle all different params? If url has a params which exactly doesn't exist in this dashboard, how can we handle it?

@rashidkpc
Copy link
Contributor

  1. There will always be at least 1 query present, as Kibana does not allow you to remove the sole remaining query
  2. At very least type should be handled, as there will soon be a regular expression search type

@abraxxa
Copy link

abraxxa commented Aug 19, 2013

There is no such thing as 'queries already present' because http is stateless and Kibana has no session as far as I know so a GET request for a dashboard with a query parameter should set the query to that value.
Maybe assigning IDs to each dashboard component and using those IDs to set values would make sense to have a more general approach e.g. search.query=foo&timepicker.mode=relative&timepicker.startdate=2013-08-19T00:00:00

@rashidkpc
Copy link
Contributor

I'm going to close this for now, This will be implemented soon, I just want to make sure its the right level of dynamic and has the structure to allow for future url passed params.

@rashidkpc rashidkpc closed this Aug 27, 2013
@spyroslalos spyroslalos mentioned this pull request Sep 25, 2013
spalger pushed a commit to spalger/kibana that referenced this pull request Mar 3, 2016
to allow indexing when `rest.action.multi.allow_explicit_index: false` is set.

Closes elastic#361
harper-carroll pushed a commit to harper-carroll/kibana that referenced this pull request Jul 11, 2016
w33ble pushed a commit to w33ble/kibana that referenced this pull request Sep 13, 2018
* Created download button component for assets

* Added download component to asset manager

* Added click handler for downloading assets

* Installed mime package. Added extension property to object returned by dataurl.parse. Updated click handler in download component.

* Added css to make asset-download float right like asset-copy

* removed console log in dataurl

* Updated styles for asset manager

* Added title attributes to download and clipboard buttons for tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants