Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Define and use internal log source #36271

Conversation

weltenwort
Copy link
Member

@weltenwort weltenwort commented May 8, 2019

Summary

This defines an internal log source in the infra plugin. The internal log source is used via the link to the Logs UI in the Elasticsearch node detail page of the Monitoring UI.

This should be the missing piece that remained after #31275.

Relates to #31657.

Checklist

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/infrastructure-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort weltenwort force-pushed the stack-monitoring-define-internal-log-source branch from 2fd0f8e to fe6a8db Compare May 8, 2019 17:28
@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort weltenwort force-pushed the stack-monitoring-define-internal-log-source branch from f0530d9 to c23d925 Compare May 9, 2019 11:03
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@weltenwort weltenwort force-pushed the stack-monitoring-define-internal-log-source branch from c23d925 to 68ec794 Compare May 10, 2019 19:25
@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort weltenwort force-pushed the stack-monitoring-define-internal-log-source branch from 68ec794 to 860a83d Compare May 10, 2019 20:05
@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort weltenwort force-pushed the stack-monitoring-define-internal-log-source branch from 860a83d to a1dc790 Compare May 10, 2019 22:06
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@weltenwort
Copy link
Member Author

weltenwort commented May 11, 2019

@elastic/stack-monitoring would you be interested in taking over this PR? I created it as a demonstration of how to use the api introduced in #36066.

@cachedout
Copy link
Contributor

@chrisronline Could you take a look at the request from @weltenwort above?

@chrisronline
Copy link
Contributor

@cachedout @weltenwort

Absolutely. Thanks for putting this together!

@jasonrhodes
Copy link
Member

@chrisronline @elastic/stack-monitoring I'm going to remove the logs UI label and leave the version labels for you all to handle how you like. Just a heads up 👍

@jasonrhodes jasonrhodes added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Jun 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort weltenwort added Team:Monitoring Stack Monitoring team and removed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jun 17, 2019
@weltenwort
Copy link
Member Author

@cachedout since you expressed interest in more stack-monitoring/logs-ui integration today, let me bring this to your attention again 😉 feel free to close it if you don't think you'll make use of it

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cachedout
Copy link
Contributor

@igoristic This is an issue you should probably be aware of now that you've taken over some of the logging projects for the team. Let me or @weltenwort know if you have questions about the history here.

@chrisronline
Copy link
Contributor

We already implemented this in another PR, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Monitoring Stack Monitoring team v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants