-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tinymath] use the es5 build #38911
Merged
Merged
[tinymath] use the es5 build #38911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
Team label for Operations Team
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v8.0.0
v7.3.0
labels
Jun 13, 2019
Pinging @elastic/kibana-operations |
Pinging @elastic/kibana-canvas |
spalger
added
the
release_note:skip
Skip the PR/issue when compiling release notes
label
Jun 13, 2019
mistic
approved these changes
Jun 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cqliu1
approved these changes
Jun 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
FrankHassanabad
approved these changes
Jun 13, 2019
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jun 13, 2019
spalger
pushed a commit
that referenced
this pull request
Jun 13, 2019
7.x/7.3: c0eba77 |
This was referenced Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v7.3.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #38857
Upgrading the tinymath library broke IE11, because the build system was rewritten and now the IE11 compatible build has to be explicitly chosen, as we're doing here with the tinymath webpack shim.