Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement saved queries and filters #39140

Merged
merged 238 commits into from
Aug 21, 2019
Merged
Show file tree
Hide file tree
Changes from 234 commits
Commits
Show all changes
238 commits
Select commit Hold shift + click to select a range
a3f2ca8
Adds saved query to data mappings
TinaHeiligers Jun 7, 2019
d934765
Merge remote-tracking branch 'upstream/master' into saved_filters
Bargs Jun 10, 2019
e76067c
Loading saved query in discover
Bargs Jun 10, 2019
188551e
Create SavedQuery type and add it as a prop to the SearchBar
Bargs Jun 10, 2019
aebd5bd
adds conditional for filters and timefilters
TinaHeiligers Jun 11, 2019
fd297f0
Adds append to suggestions component
TinaHeiligers Jun 11, 2019
9dfc92c
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 11, 2019
39ee55e
hard codes styling and saved query title
TinaHeiligers Jun 11, 2019
e960475
Pass SavedQuery down through the SearchBar components and add
Bargs Jun 11, 2019
a08ffec
Add ability to save current query. Needs some bug fixes and polish.
Bargs Jun 11, 2019
e85211b
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 12, 2019
0fc7a12
re-add save button
Bargs Jun 12, 2019
239c446
wrap title in flex item
Bargs Jun 12, 2019
cab055a
Fix apparent bug in getDerviedStateFromProps. Query should only update
Bargs Jun 12, 2019
3f2e95a
Move modal into its own component and use it in the SearchBar
Bargs Jun 12, 2019
99194ca
Check explicitly for undefined
Bargs Jun 12, 2019
9d1af7f
Move state caching to SearchBar
Bargs Jun 12, 2019
0fa0a10
Close modal on query save success
Bargs Jun 12, 2019
334dd10
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 13, 2019
62225dc
changed savedQuery type to allow for undefined
TinaHeiligers Jun 13, 2019
453e8b8
preserves saved query on state after submit
TinaHeiligers Jun 13, 2019
2c399eb
Display success and error messages on save
Bargs Jun 13, 2019
3ce41d7
Link to saved objects management page
Bargs Jun 13, 2019
4be53f7
Add ability to update an existing saved query
Bargs Jun 13, 2019
5455272
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 14, 2019
45e03f8
Loads saved queries into suggestions
TinaHeiligers Jun 14, 2019
75d240f
add description to saved query suggestion
Bargs Jun 14, 2019
0dc4d90
Add ability to load saved queries from autocomplete
Bargs Jun 14, 2019
32f2654
Adds save as new query functionality
TinaHeiligers Jun 17, 2019
0157959
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 17, 2019
3f9e88f
Fix isDirty and add Save As New when not dirty
Bargs Jun 17, 2019
0f13705
Add saved query management popover
Bargs Jun 17, 2019
841aff0
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 18, 2019
f7279a1
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 19, 2019
afcaa35
WIP adding saved queries to the dashboard app
TinaHeiligers Jun 19, 2019
2b566a1
Support saved queries in Dashboard
Bargs Jun 20, 2019
5f40fbf
Merge remote-tracking branch 'upstream/master' into saved_filters
Bargs Jun 20, 2019
36d1e2f
Add back changes lost in merge
Bargs Jun 20, 2019
103c082
add saved query to visualize
Bargs Jun 20, 2019
5bb384c
Update Discover to be consistent with Dashboard and Visualize
Bargs Jun 20, 2019
8b57318
Update app permissions to include saved query access
Bargs Jun 20, 2019
239f3b4
Merge remote-tracking branch 'upstream/master' into saved_filters
Bargs Jun 20, 2019
a8fb548
Fixes types
TinaHeiligers Jun 20, 2019
2135698
Start tests for saved query service
Bargs Jun 20, 2019
c320f79
Adds 'undefined' as a type to SavedObjectsAttributes
TinaHeiligers Jun 21, 2019
f819778
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 21, 2019
f46c70c
Adds Error thrown test
TinaHeiligers Jun 21, 2019
2af20f6
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 21, 2019
d3cecb3
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 24, 2019
b786886
Updates QueryBar and QueryBarInput snapshots
TinaHeiligers Jun 24, 2019
1406c66
Fixes saved searches icon in test
TinaHeiligers Jun 24, 2019
21b3d62
Replaces query-bar with search-bar
TinaHeiligers Jun 24, 2019
aef3d4b
Changes search icon from search to discoverApp for saved search integ…
TinaHeiligers Jun 24, 2019
cb43322
changes icon from search to discoverApp for saved_search integration …
TinaHeiligers Jun 24, 2019
c3e3504
Replaces the query-bar with the search-bar, hiding the filters from t…
TinaHeiligers Jun 24, 2019
7fd8453
Merge branch 'saved_filters_maps_app' into saved_filters
TinaHeiligers Jun 24, 2019
86cd42e
Changes 'search' icon to 'discoverApp' for saved searches missed before
TinaHeiligers Jun 25, 2019
c13f764
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 25, 2019
45b1cc7
removes commented out code, undoes comma deletion in kibana/index.js
TinaHeiligers Jun 25, 2019
75c000d
Adds Search Bar back
TinaHeiligers Jun 25, 2019
22d0273
Changes QueryBar to SearchBar in the FilterEditor, adds a customSubmi…
TinaHeiligers Jun 25, 2019
c4e8751
Adds saved_object type query to test expectation array
TinaHeiligers Jun 26, 2019
c2bdc0a
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 26, 2019
74aacc8
Allows Saved Queries to be saved and edited in Maps
TinaHeiligers Jun 26, 2019
6b1ba4f
Deletes unused Eui component from saved_query_row
TinaHeiligers Jun 27, 2019
d1d563b
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 27, 2019
d2d62ee
Fixes maps nav bar to handle saved queries
TinaHeiligers Jun 27, 2019
3e41043
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jun 28, 2019
2beb927
Loads a saved query into the layer filter query bar, allows saving ch…
TinaHeiligers Jun 28, 2019
1fae81b
Layer filter query search bar closes after selecting and saving a sav…
TinaHeiligers Jun 28, 2019
52a49b7
Changes QueryBar to SearchBar in maps layer_panel join_editor where_e…
TinaHeiligers Jun 28, 2019
4877f48
Merge branch 'saved_filters' of github.com:TinaHeiligers/kibana into …
TinaHeiligers Jun 28, 2019
361d1e2
Enables saving queries, saving changes to saved queries, using saved …
TinaHeiligers Jun 28, 2019
d5a152b
Enables saved queries to be used, created and modified in the where c…
TinaHeiligers Jun 28, 2019
663586b
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jul 8, 2019
36b0bd3
fixes setting time filter in map_controller
TinaHeiligers Jul 8, 2019
ecb8925
Conditionally shows filters and time filter option in the save query …
TinaHeiligers Jul 8, 2019
ad667b3
fixes show filter options type
TinaHeiligers Jul 9, 2019
8bd9468
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jul 9, 2019
f86b201
corrects routing to saved objects
TinaHeiligers Jul 9, 2019
62da75a
typing
TinaHeiligers Jul 9, 2019
d16da8b
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jul 9, 2019
5218ab5
begins work on the clear saved query functionality
TinaHeiligers Jul 9, 2019
9de64a6
fixes onClose type
TinaHeiligers Jul 9, 2019
d8ef743
updates query_bar snapshot
TinaHeiligers Jul 10, 2019
ba78c4b
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jul 10, 2019
448dcfa
implements close savedQuery in Discover
TinaHeiligers Jul 10, 2019
aecfc18
Updates query_bar snapshot
TinaHeiligers Jul 10, 2019
6242426
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jul 11, 2019
703c38e
Support close button in Visualize
Bargs Jul 11, 2019
47cd2f3
Support close button in Dashboard
Bargs Jul 11, 2019
dedca56
Support close button in Maps main search bar
Bargs Jul 11, 2019
6ee50e4
Make onClearSavedQuery handler optional
Bargs Jul 11, 2019
3486390
Add privileges for saved queries if user has access to maps
Bargs Jul 11, 2019
e1e15a5
Fix issue where watcher was overriding saved search that had just bee…
Bargs Jul 11, 2019
13e4c6f
Conditionally show query saving UI based on uiCapabilities
Bargs Jul 11, 2019
d954da0
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jul 12, 2019
e60c63f
Adds security around saved queries to dashboard
TinaHeiligers Jul 12, 2019
f6707e8
Adds security aroung saved queries to visualize
TinaHeiligers Jul 12, 2019
86c8f11
Adds security around saved queries to main map query bar with date pi…
TinaHeiligers Jul 12, 2019
261e107
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jul 15, 2019
361e8af
Merge remote-tracking branch 'upstream/master' into saved_filters
Bargs Jul 16, 2019
7856d93
Use the ID as a key if the suggestion type is savedQuery
Bargs Jul 16, 2019
3f170c3
Tighten type definition for prepend prop
Bargs Jul 16, 2019
f65efd9
Merge remote-tracking branch 'upstream/master' into saved_filters
Bargs Jul 17, 2019
a3845c6
Add security functional tests for the all permissions scenario
Bargs Jul 17, 2019
52dd391
Add security functional tests for the read only scenario
Bargs Jul 17, 2019
1eace53
Fixes suggestions and suggestion component jest tests
TinaHeiligers Jul 18, 2019
0fd4309
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jul 18, 2019
ccb0802
Adds security tests for saved queries to the dashboard functional tests
TinaHeiligers Jul 18, 2019
bf06d9f
Adds security tests for saved queries to the visualize functional tests
TinaHeiligers Jul 18, 2019
db622a9
Create saved query manager component
Bargs Jul 18, 2019
51cf96e
Add Saved Query links to the management popover
Bargs Jul 18, 2019
e6fc105
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Jul 19, 2019
309b5ad
Adds paragraph content to the saved query manager when there are no s…
TinaHeiligers Jul 19, 2019
d3353b5
Adds all buttons and an icon for deleting a saved query. The buttons …
TinaHeiligers Jul 19, 2019
ae1697a
Button grouping
TinaHeiligers Jul 19, 2019
6a5abff
Merge remote-tracking branch 'upstream/master' into saved_filters
Bargs Aug 1, 2019
2e1f903
Add files missed in merge commit
Bargs Aug 1, 2019
f972fa3
Fix infinite loop and refresh saved query list when management popover
Bargs Aug 1, 2019
7ae43bb
Merge remote-tracking branch 'upstream/master' into saved_filters
Bargs Aug 2, 2019
564339e
Remove saved queries from maps for now
Bargs Aug 2, 2019
de63765
Correct spacing between query manager buttons
Bargs Aug 2, 2019
c5aaa30
Hook up delete button in saved query manager
Bargs Aug 2, 2019
b44c416
resolved type error, adds query to expectInvalidTypeSpecified array
TinaHeiligers Aug 2, 2019
bc6a00e
deletes unused translations
TinaHeiligers Aug 2, 2019
e99bfcf
Adds jest tests for saved_query_service
TinaHeiligers Aug 2, 2019
ce480c6
Adds description to the saved search popover on save
TinaHeiligers Aug 2, 2019
5856695
fixes unused translations
TinaHeiligers Aug 2, 2019
5ed067a
Merge remote-tracking branch 'upstream/master' into saved_filters
Bargs Aug 5, 2019
9685145
Remove saved query UI from autocomplete suggestions
Bargs Aug 5, 2019
6e9deef
Use the same class the datepicker uses to make the prepend element the
Bargs Aug 5, 2019
644c410
always show save as new when a saved query is loaded
Bargs Aug 5, 2019
9aba13c
Merge remote-tracking branch 'upstream/saved_filters' into saved_filters
Bargs Aug 5, 2019
d20c2f8
Fix search bar jest tests
Bargs Aug 5, 2019
e196c8a
fix functional test
Bargs Aug 5, 2019
b8fff34
Merge remote-tracking branch 'upstream/master' into saved_filters
Bargs Aug 6, 2019
ad610ee
Include filters by default in saved queries
Bargs Aug 6, 2019
e41e85f
Don't allow saved queries with duplicate titles
Bargs Aug 6, 2019
c12d5f7
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Aug 7, 2019
99df809
Adds pagination to the saved query manager
TinaHeiligers Aug 7, 2019
00ecc89
changes page count to 50
TinaHeiligers Aug 7, 2019
c20f97f
Use overflow hidden so native scroll bar doesn't appear
Bargs Aug 7, 2019
5f71f65
Add saved query deletion confirmation modal
Bargs Aug 7, 2019
8634211
fix "no saved queries" copy and internationalize it
Bargs Aug 7, 2019
77142c6
add aria-labeledby to saved query list so users know what the list is…
Bargs Aug 7, 2019
a7b4421
Add extra description of open button for screen reader
Bargs Aug 7, 2019
d89d75e
add aria-label to delete button
Bargs Aug 7, 2019
1f2d98a
sentence case
Bargs Aug 7, 2019
1785437
Add aria-label to the save as new button
Bargs Aug 7, 2019
dc3c7b6
add aria-label to save changes button
Bargs Aug 7, 2019
1916608
Add aria-label to clear button
Bargs Aug 7, 2019
a2a5a14
Add aria-label to save button
Bargs Aug 7, 2019
dba23c0
Merge remote-tracking branch 'upstream/master' into saved_filters
Bargs Aug 8, 2019
9c032e9
Translate static text
Bargs Aug 8, 2019
ae5ecff
translate query bar message we noticed was static
Bargs Aug 8, 2019
9f7c71c
Move conditional one level up so we hide the button as well as the text
Bargs Aug 8, 2019
969a49e
Remove duplicate translation ID
Bargs Aug 8, 2019
3d178c6
update saved query service tests now that title is used as ID
Bargs Aug 8, 2019
2e2f746
add test for deleteSavedQuery method
Bargs Aug 8, 2019
4ca6e1b
Updating discover security functional tests to check popover instead of
Bargs Aug 8, 2019
fcfbf03
Add info icon with description of saved query
Bargs Aug 8, 2019
5bc3520
don't show delete button when user doesn't have save query write perms
Bargs Aug 8, 2019
0395adb
Test that delete button shows when user has saved query write perms
Bargs Aug 8, 2019
2342dae
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Aug 9, 2019
0e7b2a3
Adds empty query as delay for deleting a saved query test
TinaHeiligers Aug 9, 2019
72753df
Adds test for loading a saved query as a discover read-only user
TinaHeiligers Aug 9, 2019
95abe15
Adds test for a readonly discover user not being able to delete a sav…
TinaHeiligers Aug 9, 2019
70a0783
Adds test to ensure discovery readonly user cannot save changes to a …
TinaHeiligers Aug 9, 2019
750aa30
Test that clear button works as a discover readonly user
TinaHeiligers Aug 9, 2019
b9e7ec0
Adds saved query tests to dashboard as a dashboard & embeddable all p…
TinaHeiligers Aug 9, 2019
9eea8ec
Adds saved query manager interactions tests as a dashboard read-only …
TinaHeiligers Aug 9, 2019
057933c
Adds saved query manager interaction tests to visualize
TinaHeiligers Aug 9, 2019
4918baa
Fixes typo in visualize security test
TinaHeiligers Aug 9, 2019
2272757
Merge remote-tracking branch 'upstream/master' into saved_filters
Bargs Aug 12, 2019
259370e
Fix type error
Bargs Aug 12, 2019
4ec7c16
Use uiSettings for time defaults
Bargs Aug 12, 2019
53e07b0
Be consistent with our variable use
Bargs Aug 12, 2019
1c01c53
condense imports
Bargs Aug 12, 2019
85d8fc3
use default prop values
Bargs Aug 12, 2019
8a5d176
Explain why time filter is not included by default
Bargs Aug 12, 2019
b04108e
Get rid of our own RefreshInterval
Bargs Aug 12, 2019
8c9cc22
Use the timefilter TimeRange type
Bargs Aug 12, 2019
25cbeeb
Merge remote-tracking branch 'upstream/saved_filters' into saved_filters
Bargs Aug 12, 2019
4478b39
Use version 8 style import
Bargs Aug 12, 2019
8c69437
Reuse existing type now that it is not throwing an error
Bargs Aug 12, 2019
c83873d
SearchBar is already exported for the top level of the plugin
Bargs Aug 12, 2019
763f350
Use removeAll
Bargs Aug 12, 2019
1dc9044
Use existing type definition
Bargs Aug 12, 2019
ffe3a13
Give tooltip an aria-label
Bargs Aug 12, 2019
c605d8a
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Aug 13, 2019
ba733b2
Remove unnecessary exports
Bargs Aug 13, 2019
f68dcc7
Rename SavedQueryManager to SavedQueryManagementComponent
Bargs Aug 13, 2019
fc14cca
Highlights currently selected saved query and moves it to the top of …
TinaHeiligers Aug 13, 2019
ab46fff
Makes a saved query bold only if it's selected
TinaHeiligers Aug 14, 2019
4ce22c7
loading a saved query functional test fix WIP
TinaHeiligers Aug 14, 2019
d1b78b3
Removes unused EuiSpacer
TinaHeiligers Aug 14, 2019
8373e06
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Aug 14, 2019
2b3103d
Finds selected saved query by additional data-test-subject selector
TinaHeiligers Aug 14, 2019
e476338
Replaces 'manager' with 'management component' in saved queries funct…
TinaHeiligers Aug 14, 2019
6bd72b8
Adds more aria labels to the saved query management component
TinaHeiligers Aug 14, 2019
b9bfb18
Adds tooltip to the delete button, modifies descriptions text
TinaHeiligers Aug 14, 2019
a7b50a7
Extract saved query list item from management component
Bargs Aug 14, 2019
e7b757b
Remove unused prop
Bargs Aug 14, 2019
2ad5099
Combine duplicate buttons
Bargs Aug 14, 2019
7c49a60
Add title conflict validation to save query form
Bargs Aug 14, 2019
fd487d5
inject savedObjectsClient into saved query service
Bargs Aug 14, 2019
3b01d3d
Merge remote-tracking branch 'upstream/master' into saved_filters
Bargs Aug 15, 2019
2708fad
Closes the SavedQueryManagementComponent after deleting a saved query…
TinaHeiligers Aug 15, 2019
2fcc1eb
Fixes bug with deleting a loaded saved query
TinaHeiligers Aug 15, 2019
2cc232b
reverts local changes
TinaHeiligers Aug 15, 2019
d57058a
deletes unused code
TinaHeiligers Aug 15, 2019
f411ddf
Removes accessibility duplication
TinaHeiligers Aug 15, 2019
f80c912
Removes unused imports
TinaHeiligers Aug 15, 2019
859dce5
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Aug 16, 2019
af59279
initial setup of general saved query management component functional …
TinaHeiligers Aug 16, 2019
fa2a0b6
Adds saved queries to OSS uiCapabilities
TinaHeiligers Aug 16, 2019
382b20e
Adds general saved query management component functional tests
TinaHeiligers Aug 17, 2019
1d5a766
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Aug 19, 2019
08a3683
Adds changes to kbn_top_nav lost during deletion of kbn_top_nav2
TinaHeiligers Aug 19, 2019
4f40b1e
Refactors tests and adds test for saving with a non-unique name
TinaHeiligers Aug 19, 2019
cad350f
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Aug 19, 2019
e609af2
Adds back time filter test
TinaHeiligers Aug 19, 2019
2cb9416
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Aug 20, 2019
5f3329b
Refactors checking saving changes to a currently loaded query
TinaHeiligers Aug 20, 2019
bc3fdf2
Adds check to clearing a saved query to ensure the query bar has been…
TinaHeiligers Aug 20, 2019
4787319
Improve saved query mappings
Bargs Aug 20, 2019
1d0d1f0
remove skip firefox tag
Bargs Aug 20, 2019
7b0e2af
Merge remote-tracking branch 'upstream/master' into saved_filters
Bargs Aug 20, 2019
f4d861c
Fix tests
Bargs Aug 20, 2019
2f3f472
Merge branch 'master' of github.com:elastic/kibana into saved_filters
TinaHeiligers Aug 21, 2019
458d043
Changes mappings type
TinaHeiligers Aug 21, 2019
ae57041
uses explicity type rather than type-casting
TinaHeiligers Aug 21, 2019
a922444
Uses explicit SavedQuery type over 'any'
TinaHeiligers Aug 21, 2019
f143236
Adds whitespace validation on a new saved query title
TinaHeiligers Aug 21, 2019
daaabb9
Adds whitespace validation hint text
TinaHeiligers Aug 21, 2019
664804d
Trims new saved query title before save in the saved query service, m…
TinaHeiligers Aug 21, 2019
ee27111
Adds general functional test for whitespace name error
TinaHeiligers Aug 21, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import Boom from 'boom';
import { getProperty, IndexMapping } from '../../../mappings';

const TOP_LEVEL_FIELDS = ['_id'];
const TOP_LEVEL_FIELDS = ['_id', '_score'];

export function getSortingParams(
mappings: IndexMapping,
Expand Down
19 changes: 19 additions & 0 deletions src/legacy/core_plugins/data/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

import { resolve } from 'path';
import { Legacy } from '../../../../kibana';
import { mappings } from './mappings';
import { SavedQuery } from './public';

// eslint-disable-next-line import/no-default-export
export default function DataPlugin(kibana: any) {
Expand All @@ -35,6 +37,23 @@ export default function DataPlugin(kibana: any) {
uiExports: {
injectDefaultVars: () => ({}),
styleSheetPaths: resolve(__dirname, 'public/index.scss'),
mappings,
savedObjectsManagement: {
query: {
icon: 'search',
defaultSearchField: 'title',
isImportableAndExportable: true,
getTitle(obj: SavedQuery) {
return obj.attributes.title;
},
getInAppUrl(obj: SavedQuery) {
return {
path: `/app/kibana#/discover?_a=(savedQuery:'${encodeURIComponent(obj.id)}')`,
Bargs marked this conversation as resolved.
Show resolved Hide resolved
uiCapabilitiesPath: 'discover.show',
};
},
},
},
},
};

Expand Down
50 changes: 50 additions & 0 deletions src/legacy/core_plugins/data/mappings.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

export const mappings = {
query: {
properties: {
title: {
type: 'text',
},
description: {
type: 'text',
},
query: {
properties: {
language: {
type: 'keyword',
},
query: {
type: 'keyword',
index: false,
},
},
},
filters: {
type: 'object',
enabled: false,
},
timefilter: {
type: 'object',
enabled: false,
},
},
},
};
1 change: 1 addition & 0 deletions src/legacy/core_plugins/data/public/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@

@import './filter/filter_bar/index';

@import './search/search_bar/index';
2 changes: 1 addition & 1 deletion src/legacy/core_plugins/data/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export {
StaticIndexPattern,
} from './index_patterns';
export { Query, QueryBar, QueryBarInput } from './query';
export { SearchBar, SearchBarProps } from './search';
export { SearchBar, SearchBarProps, SavedQueryAttributes, SavedQuery } from './search';

/** @public static code */
export * from '../common';
Expand Down
2 changes: 1 addition & 1 deletion src/legacy/core_plugins/data/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export class DataPlugin implements Plugin<DataSetup, void, DataPluginSetupDepend
indexPatterns: indexPatternsService.indexPatterns,
}),
query: this.query.setup(),
search: this.search.setup(),
search: this.search.setup(savedObjectsClient),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Other services pass in objects

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizozom are you just saying you'd prefer this:

this.search.setup({ savedObjectsClient })

?

};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ describe('QueryBar', () => {
indexPatterns={[mockIndexPattern]}
store={createMockStorage()}
intl={null as any}
onChange={noop}
isDirty={false}
/>
);

Expand All @@ -125,6 +127,8 @@ describe('QueryBar', () => {
store={createMockStorage()}
disableAutoFocus={true}
intl={null as any}
onChange={noop}
isDirty={false}
/>
);

Expand All @@ -136,6 +140,8 @@ describe('QueryBar', () => {
<QueryBar.WrappedComponent
uiSettings={setupMock.uiSettings}
onSubmit={noop}
onChange={noop}
isDirty={false}
appName={'discover'}
store={createMockStorage()}
intl={null as any}
Expand All @@ -151,6 +157,8 @@ describe('QueryBar', () => {
<QueryBar.WrappedComponent
uiSettings={setupMock.uiSettings}
onSubmit={noop}
onChange={noop}
isDirty={false}
appName={'discover'}
store={createMockStorage()}
intl={null as any}
Expand All @@ -167,6 +175,8 @@ describe('QueryBar', () => {
<QueryBar.WrappedComponent
uiSettings={setupMock.uiSettings}
onSubmit={noop}
onChange={noop}
isDirty={false}
appName={'discover'}
screenTitle={'Another Screen'}
store={createMockStorage()}
Expand All @@ -187,6 +197,8 @@ describe('QueryBar', () => {
uiSettings={setupMock.uiSettings}
query={kqlQuery}
onSubmit={noop}
onChange={noop}
isDirty={false}
appName={'discover'}
screenTitle={'Another Screen'}
indexPatterns={[mockIndexPattern]}
Expand All @@ -206,6 +218,8 @@ describe('QueryBar', () => {
uiSettings={setupMock.uiSettings}
query={kqlQuery}
onSubmit={noop}
onChange={noop}
isDirty={false}
appName={'discover'}
screenTitle={'Another Screen'}
indexPatterns={[mockIndexPattern]}
Expand All @@ -225,6 +239,8 @@ describe('QueryBar', () => {
<QueryBar.WrappedComponent
uiSettings={setupMock.uiSettings}
onSubmit={noop}
onChange={noop}
isDirty={false}
appName={'discover'}
screenTitle={'Another Screen'}
store={createMockStorage()}
Expand Down
Loading