Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel Discover fetch requests if a new one is submitted #39963

Merged
merged 3 commits into from
Jul 10, 2019
Merged

Cancel Discover fetch requests if a new one is submitted #39963

merged 3 commits into from
Jul 10, 2019

Conversation

lukasolson
Copy link
Member

Resolves #14544.

This PR updates Discover to cancel any existing fetches when a new fetch is requested.

@lukasolson lukasolson self-assigned this Jun 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

lukeelmers
lukeelmers approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested Chrome OSX, with dev tools throttling to "slow 3g speeds". Confirmed that when rapidly switching between time ranges, msearch requests that were still in flight got canceled.

src/legacy/core_plugins/kibana/public/discover/controllers/discover.js Show resolved Hide resolved
@ppisljar
Copy link
Member

ppisljar commented Jul 3, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger spalger added the v7.4.0 label Jul 3, 2019
ppisljar
ppisljar approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, waiting for CI to go green

@lukasolson lukasolson force-pushed the cancelDiscoverRequests branch from 1fb0527 to 91a1455 Compare July 10, 2019 17:59
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lukasolson lukasolson merged commit ea3360e into elastic:master Jul 10, 2019
lukasolson added a commit that referenced this pull request Jul 10, 2019
@lukasolson
Cancel Discover fetch requests if a new one is submitted (#39963)
bb6d668 
* Cancel discover fetch requests if a nnew one is submitted

* Add comment

* Remove unused translations
lukasolson added a commit that referenced this pull request Jul 10, 2019
@lukasolson
Cancel Discover fetch requests if a new one is submitted (#39963)
6a0d827 
* Cancel discover fetch requests if a nnew one is submitted

* Add comment

* Remove unused translations
@lukasolson
Copy link
Member Author

7.x (7.4.0): bb6d668
7.3 (7.3.0): 6a0d827

@lukasolson lukasolson mentioned this pull request Jul 23, 2019
Closed
22 tasks
@lukasolson lukasolson mentioned this pull request Aug 6, 2019
Merged
1 task
@lukasolson lukasolson deleted the cancelDiscoverRequests branch December 2, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees

@lukasolson lukasolson

Labels
Feature:Discover Discover Application release_note:fix v7.3.0 v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancel outstanding requests when new time period is selected
5 participants
@lukasolson @elasticmachine @ppisljar @lukeelmers @spalger