Allow sorting when index is missing sort field #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I'm not exactly sure what's happening here, but it looks like the sorting is behaving funkily:
If you look at the response inside the spy panel, you'll see it's coming back in a different order, so I'm not sure why this is happening. |
|
That shouldn't be related to this change. Maybe something broken in the resort of the segmented fetch? |
|
LGTM. |
lukasolson
added a commit
that referenced
this pull request
Jun 2, 2015
Allow sorting when index is missing sort field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3125 and allows for sorting on a field even when it doesn't exist in an index. This manifests itself primarily in timestamped index patterns in which the field may not be present in all indices.
All indices in which the field is missing are instructed to treat the field as if it exists and is of type
boolean. The effect is that the value will end up beingnullfor missing fields.In addition, this removes
getNormalizedSortas it wasn't used anywhere.