Allow terms_stats facet via terms module #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Styles look broken in editor. Maybe |
|
You are right about this, but it is only cosmetic problem. Did you try functionality? |
|
Yep, I tried it. Looks like query and numbers are correct :) |
|
Great |
|
A few notes here: Please see the https://github.com/elasticsearch/kibana/blob/master/CONTRIBUTING.md for the steps to be completed before this can be merged. |
|
I am closing this pull request. I will submit new pull request with changes described in this pull request. |
harper-carroll
pushed a commit
to harper-carroll/kibana
that referenced
this pull request
Jul 11, 2016
Updated metadata list from Qosmos and from talking to labs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch terms_stats facet implemented in terms module. Some changes have been made in editor.html and module.js. You can choose standard terms or terms_stats facet in definition of the panel.