[Vis: Default editor] Create vis_options_react_wrapper #41746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sulemanof
added
release_note:skip
|
Pinging @elastic/kibana-app |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
flash1293
approved these changes
Jul 24, 2019
maryia-lapata
approved these changes
Jul 24, 2019
| sinon.assert.calledOnce(stageEditorParams); | ||
| sinon.assert.calledWith(stageEditorParams, sinon.match(expectedParams)); | ||
| }); | ||
| expect(component).toMatchSnapshot(); // eslint-disable-line |
There was a problem hiding this comment.
Why is this line disabled for eslint?
There was a problem hiding this comment.
Seems something legacy and could be removed.
Will be removed in the next pr
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Jul 24, 2019
* Add vis_options_react_wrapper * Update jest tests * Fix plugin functional test
sulemanof
added a commit
that referenced
this pull request
Jul 24, 2019
💚 Build Succeeded |
timroes
added
the
release_note:plugin_api_changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A part of #38273.
This includes next changes:
vis-options-react-wrapperdirective which handles React.Component editors (using ngReact);VisOptionsReactWrapperas a HOC for rendering thecomponentprop;input_control_viseditors due to updated props;input_control_viseditors test cases;Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers
Dev Docs
API change of React visualization editor
The properties that get passed into a React visualization editor have slightly been changed:
editorState.params→stateParamsstageEditorParams(newParams)→setValue(paramName: string, paramValue: unknown)(meaning that you can now set individual parameters in the editor without needing to copy over the previous params.scopehas been removed, which gave direct access to an Angular scope.vishas been added to the properties to access the underlyingVisobject directly.You can check the custom visualization sample plugin for an always up to date example of building custom visualizations.