[Vis: Default editor] EUIficate tag cloud options tab #42070

sulemanof · 2019-07-26T14:10:43Z

Summary

A part of #38273.
EUIfication of the Options tab in the Tag cloud vis.

This includes:

reused the ValidatedDualRange component with existing validation (it's used in Maps plugin), the component is also extended with additional props;
capitalized and made wrapped in i18n all labels in select options in tag cloud config collections and pie chart config collections;
removed no-ui-slider lib, since it was only used there;

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

…ns/pie

sulemanof · 2019-07-26T14:56:09Z

@cchaos could you please take a look ? Maybe you have any suggestions

elasticmachine · 2019-07-26T15:09:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

cchaos · 2019-07-26T16:20:41Z

Looking at the screenshot, I'd say put the unit of measure (pixels) in the form label and remove the labels.

…ns/pie

…loud

…ns/tag_cloud

sulemanof · 2019-07-29T11:04:55Z

Looking at the screenshot, I'd say put the unit of measure (pixels) in the form label and remove the labels.

@cchaos thanks !
The PR is updated due to changes request and is ready for review!

elasticmachine · 2019-07-29T11:57:41Z

Pinging @elastic/kibana-app

elasticmachine · 2019-07-29T12:59:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

sulemanof · 2019-07-29T13:40:41Z

retest

…ns/tag_cloud

elasticmachine · 2019-07-29T14:51:05Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-29T15:07:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cchaos

Screenshots and code LGTM

maryia-lapata

LGTM, just small comments.
checked locally on Chrome, Mac. It works as expected.

src/legacy/core_plugins/kbn_vislib_vis_types/public/pie.js

src/legacy/ui/public/validated_range/validated_dual_range.js

…ns/tag_cloud

elasticmachine · 2019-07-30T11:00:56Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

src/legacy/core_plugins/tagcloud/public/tag_cloud_vis_options.tsx

…ns/tag_cloud

flash1293

Code LGTM, tested and works.

This is unrelated, but adding the label overflows some container an a scroll bar shows up:

Maybe due to an earlier EUIfication?

package.json

flash1293 · 2019-07-31T08:19:43Z

src/legacy/core_plugins/tagcloud/public/tag_cloud_vis_options.tsx

@@ -0,0 +1,85 @@
+/*


Nit: Maybe use tag_cloud_options.tsx as name here to match the component name.

That makes sense.
Also the components folder created for the future react components

flash1293 · 2019-07-31T08:26:08Z

x-pack/plugins/translations/translations/zh-CN.json

-    "tagCloud.visParams.maxFontSizeAriaLabel": "标记字体最大大小",
-    "tagCloud.visParams.maxPixelsAriaLabel": "像素",
-    "tagCloud.visParams.minFontSizeAriaLabel": "标记字体最小大小",
-    "tagCloud.visParams.minPixelsAriaLabel": "像素",
    "tagCloud.visParams.orientationsLabel": "方向",


Any reason the orientations label was spared?

The reason of removing other labels that they were not in sentence case (we try to follow EUI writing style guide) or labels become unnecessary, or they were changed.
Here the tagCloud.visParams.orientationsLabel stayed the same as it was -> so there was not a reason to remove it

elasticmachine · 2019-07-31T08:59:48Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

sulemanof · 2019-07-31T10:13:18Z

Code LGTM, tested and works.

This is unrelated, but adding the label overflows some container an a scroll bar shows up:

Maybe due to an earlier EUIfication?

@flash1293 thanks Joe 👍
Since it is unrelated to the PR and FMPOV has low priority, I mark the issue and will check it later

elasticmachine · 2019-07-31T11:02:56Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* EUIficate pie chart options tab * Fix tests * Size titles down to xs * Use FormattedMessage * EUIficate tag_cloud_vis options tab * Get rid of ticks in the range * Update snapshots * Fix comments * Change label * Create a components folder

sulemanof added 6 commits July 24, 2019 17:42

EUIficate pie chart options tab

52853a7

Fix tests

74f390f

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

e341057

…ns/pie

Size titles down to xs

d74abca

Use FormattedMessage

f29de74

EUIficate tag_cloud_vis options tab

237d338

sulemanof requested a review from a team as a code owner July 26, 2019 14:10

sulemanof changed the title ~~[Vis: Default editor] EUIficate tag cloud options tab~~ [WIP][Vis: Default editor] EUIficate tag cloud options tab Jul 26, 2019

sulemanof added the release_note:skip Skip the PR/issue when compiling release notes label Jul 26, 2019

sulemanof requested a review from cchaos July 26, 2019 14:55

sulemanof added 4 commits July 29, 2019 11:42

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

c4247c8

…ns/pie

Merge branch 'EUIfication/options/pie' into EUIfication/options/tag_c…

84c13e9

…loud

Get rid of ticks in the range

a4a85b2

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

3c8c783

…ns/tag_cloud

sulemanof changed the title ~~[WIP][Vis: Default editor] EUIficate tag cloud options tab~~ [Vis: Default editor] EUIficate tag cloud options tab Jul 29, 2019

sulemanof requested a review from maryia-lapata July 29, 2019 11:03

Update snapshots

5bca4ee

sulemanof added Feature:Vis Editor Visualization editor issues Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.4.0 v8.0.0 labels Jul 29, 2019

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

18c09f4

…ns/tag_cloud

cchaos approved these changes Jul 29, 2019

View reviewed changes

maryia-lapata approved these changes Jul 30, 2019

View reviewed changes

src/legacy/core_plugins/kbn_vislib_vis_types/public/pie.js Outdated Show resolved Hide resolved

src/legacy/ui/public/validated_range/validated_dual_range.js Show resolved Hide resolved

sulemanof added 2 commits July 30, 2019 12:32

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

c2768e4

…ns/tag_cloud

Fix comments

df4228c

sulemanof requested review from flash1293 and wylieconlon July 30, 2019 09:55

cchaos reviewed Jul 30, 2019

View reviewed changes

src/legacy/core_plugins/tagcloud/public/tag_cloud_vis_options.tsx Outdated Show resolved Hide resolved

sulemanof added 2 commits July 31, 2019 10:51

Change label

4dce33d

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

4459c52

…ns/tag_cloud

flash1293 approved these changes Jul 31, 2019

View reviewed changes

Create a components folder

8f07aad

sulemanof merged commit 48921a8 into elastic:master Jul 31, 2019

sulemanof deleted the EUIfication/options/tag_cloud branch July 31, 2019 12:11

sulemanof mentioned this pull request Jul 31, 2019

[7.x] [Vis: Default editor] EUIficate tag cloud options tab (#42070) #42340

Merged

sulemanof added the backported label Jul 31, 2019

timroes mentioned this pull request Jul 31, 2019

EUIficate visualization option panels #38273

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Vis: Default editor] EUIficate tag cloud options tab #42070

[Vis: Default editor] EUIficate tag cloud options tab #42070

sulemanof commented Jul 26, 2019 •

edited

Loading

sulemanof commented Jul 26, 2019

elasticmachine commented Jul 26, 2019

cchaos commented Jul 26, 2019

sulemanof commented Jul 29, 2019 •

edited

Loading

elasticmachine commented Jul 29, 2019

elasticmachine commented Jul 29, 2019

sulemanof commented Jul 29, 2019

elasticmachine commented Jul 29, 2019

elasticmachine commented Jul 29, 2019

cchaos left a comment

maryia-lapata left a comment

elasticmachine commented Jul 30, 2019

flash1293 left a comment

flash1293 Jul 31, 2019

sulemanof Jul 31, 2019

flash1293 Jul 31, 2019

sulemanof Jul 31, 2019

elasticmachine commented Jul 31, 2019

sulemanof commented Jul 31, 2019 •

edited

Loading

elasticmachine commented Jul 31, 2019

[Vis: Default editor] EUIficate tag cloud options tab #42070

[Vis: Default editor] EUIficate tag cloud options tab #42070

Conversation

sulemanof commented Jul 26, 2019 • edited Loading

Summary

Checklist

For maintainers

sulemanof commented Jul 26, 2019

elasticmachine commented Jul 26, 2019

💔 Build Failed

cchaos commented Jul 26, 2019

sulemanof commented Jul 29, 2019 • edited Loading

elasticmachine commented Jul 29, 2019

elasticmachine commented Jul 29, 2019

💔 Build Failed

sulemanof commented Jul 29, 2019

elasticmachine commented Jul 29, 2019

💚 Build Succeeded

elasticmachine commented Jul 29, 2019

💚 Build Succeeded

cchaos left a comment

Choose a reason for hiding this comment

maryia-lapata left a comment

Choose a reason for hiding this comment

elasticmachine commented Jul 30, 2019

💚 Build Succeeded

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 Jul 31, 2019

Choose a reason for hiding this comment

sulemanof Jul 31, 2019

Choose a reason for hiding this comment

flash1293 Jul 31, 2019

Choose a reason for hiding this comment

sulemanof Jul 31, 2019

Choose a reason for hiding this comment

elasticmachine commented Jul 31, 2019

💚 Build Succeeded

sulemanof commented Jul 31, 2019 • edited Loading

elasticmachine commented Jul 31, 2019

💚 Build Succeeded

sulemanof commented Jul 26, 2019 •

edited

Loading

sulemanof commented Jul 29, 2019 •

edited

Loading

sulemanof commented Jul 31, 2019 •

edited

Loading