Migrate index pattern server side to typescript #43155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
added
the
Feature:Data Views
wylieconlon
commented
Aug 12, 2019
| } | ||
| } | ||
| }, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
@lukeelmers There's an error I can't figure about the Request types here, can you take a look?
| @@ -55,9 +72,10 @@ export function indexPatternsMixin(kbnServer, server) { | |||
| * @method request.getIndexPatternsService | |||
| * @type {IndexPatternsService} | |||
| */ | |||
| server.addMemoizedFactoryToRequest('getIndexPatternsService', request => { | |||
| server.addMemoizedFactoryToRequest('getIndexPatternsService', (request: Legacy.Request) => { | |||
There was a problem hiding this comment.
The addMemoizedFactoryToRequest code doesn't seem to be present in any existing type definitions, what is it supposed to do?
| @@ -72,7 +68,7 @@ describe('index_patterns/field_capabilities/field_capabilities', () => { | |||
| describe('calls `readFieldCapsResponse`', () => { | |||
| it('passes exact es response', async () => { | |||
| stubDeps({ | |||
| esResponse: footballs[0] | |||
| esResponse: footballs[0], | |||
There was a problem hiding this comment.
@lukeelmers These test files are completely filled with errors because the way the code is called here is totally different from the actual code- suggestions?
wylieconlon
commented
Aug 12, 2019
| .reduce( | ||
| (acc, index, indexName) => acc.concat(indexName, Object.keys(index.aliases || {})), | ||
| [] as string[] | ||
| ) |
There was a problem hiding this comment.
The .reduce( call here is throwing a number of errors related to lodash that I don't understand- maybe we need to split it out into chain(aliases.reduce(...))?
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is still a WIP change
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers