Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting/API Testing] Simplify config #43216

Merged

Conversation

tsullivan
Copy link
Member

This PR remove injection of x-pack/test/functional/config.js from the Reporting API Integration test config. That include itself imports the Kibana common config, which enables the optimizer

This makes API Integration tests run faster due to no longer starting the optimizer when running these tests

- Remove injection of `x-pack/test/functional/config.js`
- No more starting the optimizer when running thees tests
@tsullivan tsullivan added review (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Stack Services v7.4.0 labels Aug 13, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services

Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tsullivan tsullivan merged commit 94a35cd into elastic:master Aug 14, 2019
@tsullivan tsullivan deleted the reporting/api-test-config-simpler branch August 14, 2019 00:42
tsullivan added a commit to tsullivan/kibana that referenced this pull request Aug 14, 2019
- Remove injection of `x-pack/test/functional/config.js`
- No more starting the optimizer when running thees tests
tsullivan added a commit that referenced this pull request Aug 15, 2019
- Remove injection of `x-pack/test/functional/config.js`
- No more starting the optimizer when running thees tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes review v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants