Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure vis plugin & export types contracts #43730

Closed
wants to merge 2 commits into from
Closed

Restructure vis plugin & export types contracts #43730

wants to merge 2 commits into from

Conversation

lukeelmers
Copy link
Member

This picks up the work that was started in #35625 and does the following:

  • Updates structure of vis plugin for consistency with our shimming conventions
  • Ensures public contracts from ui/vis that need to live in the visualizations plugin are re-exported

Next steps:

  • Actually move the code and re-export legacy contracts from ui/vis
  • Deangularization, more TS conversion, etc

@lukeelmers lukeelmers added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v8.0.0 Team:AppArch v7.4.0 Feature:NP Migration labels Aug 22, 2019
@lukeelmers lukeelmers requested a review from ppisljar August 22, 2019 00:20
@lukeelmers lukeelmers self-assigned this Aug 22, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lukeelmers lukeelmers mentioned this pull request Aug 22, 2019
Closed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

This was referenced Aug 22, 2019
Closed
Closed
@streamich streamich mentioned this pull request Aug 27, 2019
Closed
13 tasks
@lukeelmers lukeelmers mentioned this pull request Sep 4, 2019
Merged
@lukeelmers
Copy link
Member Author

closing in favor of #44839

@lukeelmers lukeelmers closed this Sep 4, 2019
@lukeelmers lukeelmers deleted the feat/vis-move branch September 4, 2019 23:52
@lukeelmers lukeelmers mentioned this pull request Sep 4, 2019
Merged
9 tasks
lukeelmers added a commit to lukeelmers/kibana that referenced this pull request Sep 9, 2019
@lukeelmers
Merge with changes from elastic#43730.
e078a78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar Awaiting requested review from ppisljar

Assignees

@lukeelmers lukeelmers

Labels
Feature:NP Migration Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukeelmers @elasticmachine