-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Sets up APM with new shared Kibana core context #43920
Changes from 2 commits
cca58f8
92e4b72
35f9b1c
2f79aa3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ import { toastNotifications } from 'ui/notify'; | |
import * as callApmApi from '../../../../services/rest/callApmApi'; | ||
import { ServiceOverview } from '..'; | ||
import * as urlParamsHooks from '../../../../hooks/useUrlParams'; | ||
import * as coreHooks from '../../../../hooks/useCore'; | ||
import * as kibanaCore from '../../../../../../observability/public/context/kibana_core'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FWIW, we only export things from For more info, see: https://stackoverflow.com/a/53307822 |
||
import { InternalCoreStart } from 'src/core/public'; | ||
import * as useLocalUIFilters from '../../../../hooks/useLocalUIFilters'; | ||
import { FETCH_STATUS } from '../../../../hooks/useFetcher'; | ||
|
@@ -39,7 +39,7 @@ describe('Service Overview -> View', () => { | |
end: 'myEnd' | ||
} | ||
}); | ||
spyOn(coreHooks, 'useCore').and.returnValue(coreMock); | ||
spyOn(kibanaCore, 'useKibanaCore').and.returnValue(coreMock); | ||
|
||
jest.spyOn(useLocalUIFilters, 'useLocalUIFilters').mockReturnValue({ | ||
filters: [], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT this is the way to let TS know what type
this.context
should be in the rest of the class, so that each reference tothis.context
doesn't need to self-type.It's weird and just another reason to eventually move all our shit away from classes :)