[Code] bundle git repo for functional test #44547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/code |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mw-ding
added
release_note:skip
mw-ding
commented
Sep 4, 2019
packages/kbn-dev-utils/src/index.ts
Outdated
| @@ -21,5 +21,5 @@ export { withProcRunner } from './proc_runner'; | |||
| export { ToolingLog, ToolingLogTextWriter, pickLevelFromFlags } from './tooling_log'; | |||
| export { createAbsolutePathSerializer } from './serializers'; | |||
| export { CA_CERT_PATH, ES_KEY_PATH, ES_CERT_PATH } from './certs'; | |||
| export { run, createFailError, createFlagError, combineErrors, isFailError } from './run'; | |||
| export { run, createFailError, createFlagError, combineErrors, isFailError, Flags } from './run'; | |||
💔 Build Failed |
💔 Build Failed |
spalger
reviewed
Sep 5, 2019
| }; | ||
|
|
||
| const repoDir = (repoUri: string, kibanaDir: string) => { | ||
| return `${kibanaDir}/data/code/repos/${repoUri}`; |
There was a problem hiding this comment.
Please use path.resolve() here and in workspaceDir()
| import fs from 'fs'; | ||
| import mkdirp from 'mkdirp'; | ||
| import path from 'path'; | ||
| import rimraf from 'rimraf'; |
There was a problem hiding this comment.
I usually use del because it does the same thing and supports promises.
💔 Build Failed |
|
@spalger this should be good by now. can you take a second look? |
💚 Build Succeeded |
💚 Build Succeeded |
spalger
approved these changes
Sep 6, 2019
|
|
||
| await retry.tryForTime(300000, async () => { | ||
| { |
There was a problem hiding this comment.
just trying to differentiate 2 minor steps in this test case , which helps to be eyeballed.
|
|
||
| await login(codeUser); | ||
| await retry.tryForTime(5000, async () => { | ||
| { |
This was referenced Sep 6, 2019
This was referenced Sep 6, 2019
mw-ding
added a commit
that referenced
this pull request
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, Code functional tests rely on importing github repositories on the fly to clone the git repository as the source of truth. This external dependency could potentially result in some flakiness to the functional tests. In this PR, we bundled zipped git bare repositories into the kibana source code and extract these repos to the right code data path instead of cloning from github.com.
https://github.com/elastic/code/issues/1605
Regarding the runtime installation path of kibana, we can integrate with @spalger 's draft PR #44552 to make it more reasonable.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers