Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mock to resolve ref issue with EuiCodeBlockImpl #44741

Closed
wants to merge 3 commits into from
Closed

Add mock to resolve ref issue with EuiCodeBlockImpl #44741

wants to merge 3 commits into from

Conversation

clintandrewhall
Copy link
Contributor

Summary

This PR addresses the bug reported in elastic/eui#2242 for Canvas Storybook snapshots. It uses the createNodeMocks functionality exposed in @storybook/addon-storyshots to create a node for the ref.

This PR also converts several files to TS and externalizes the mocks, (and fixes a couple of bugs in the mocks, as well).

@clintandrewhall clintandrewhall added review chore Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v7.5.0 labels Sep 4, 2019
@clintandrewhall clintandrewhall requested a review from a team as a code owner September 4, 2019 03:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@clintandrewhall clintandrewhall deleted the snapshot-tests branch September 18, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poffdeluxe poffdeluxe Awaiting requested review from poffdeluxe

Assignees
No one assigned
Labels
chore impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clintandrewhall @elasticmachine