update assumption that panelIndex may be missing #44793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
added
bug
💔 Build Failed |
|
Everything passed, just firefox smoke is "grey" jenkins, test this |
💚 Build Succeeded |
kertal
approved these changes
Sep 5, 2019
|
@LeeDr - any objections to backporting this to 7.4? It's an upgrade bug. Users who hit it will not be able to upgrade to 7.3 or 7.4. |
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Sep 5, 2019
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Sep 5, 2019
stacey-gammon
added a commit
that referenced
this pull request
Sep 5, 2019
stacey-gammon
added a commit
that referenced
this pull request
Sep 5, 2019
|
Backported to 7.4 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #44639.
Folks upgrading from very old Kibana instances may actually have panels in panelsJSON that are missing the
panelIndexproperty. This should only be the case whenuiStateJSONis an empty object, otherwise you needpanelIndexto map to whatever is stored in there.No one with panels like this will be able to upgrade to 7.3 without this fix, so we can continue to assume that folks who did upgrade to 7.3 or higher have panels in the right shape (e.g. I can keep the type
RawSavedDashboardPanel730ToLatestthe same, just need to change our assumptions on older type panels).We may want to consider backporting to 7.4, though, not too many issues have come in.