Default to _search instead of _msearch in courier #45174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
|
Pinging @elastic/kibana-app-arch |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
lukasolson
commented
Oct 2, 2019
| @@ -63,7 +62,7 @@ export function createProxy(server) { | |||
| body | |||
| }, { signal }); | |||
| } catch (error) { | |||
| throw handleESError(error); | |||
There was a problem hiding this comment.
This was changed in a previous PR I did, but the _search behavior is only used in two places (courier and querying matching index patterns), and both rely on the behavior of not throwing, but simply returning the response from ES.
lukasolson
commented
Oct 2, 2019
Comment on lines
-153
to
-161
| it('calls es.msearch() once, regardless of number of searchRequests', () => { | ||
| expect(fakeSearch.callCount).to.be(0); | ||
| searchRequests = [ createSearchRequest(), createSearchRequest(), createSearchRequest() ]; | ||
|
|
||
| return callClient(searchRequests).then(() => { | ||
| expect(fakeSearch.callCount).to.be(1); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Not the case any more with _search.
lukasolson
commented
Oct 2, 2019
| @@ -45,7 +45,9 @@ describe('callClient', () => { | |||
| const { source: overrideSource, ...rest } = overrides; | |||
|
|
|||
| const source = { | |||
| _flatten: () => ({}), | |||
| _flatten: () => Promise.resolve({ | |||
There was a problem hiding this comment.
In general these changes are mostly to get the tests passing for this PR, they are completely replaced anyway in this PR: #45235
lukasolson
added
Feature:Search
|
@elasticmachine merge upstream |
💚 Build Succeeded |
stacey-gammon
approved these changes
Oct 8, 2019
|
@elasticmachine merge upstream |
💚 Build Succeeded |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Oct 14, 2019
* Default to _search instead of _msearch in courier * Fix callClient tests * Revert accidental commit * Fix proxy to properly return response from ES
|
7.x (7.5.0): cf414a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just switches the default for
courier:batchSearchesto befalse.In practice this means that the default will be to use
_searchinstead of_msearchin Elasticsearch by default. It paves the way to make more significant refactorings in courier and search source.Release Note
The default setting for
courier:batchSearchesis nowfalse, which means that search requests will use the_searchElasticsearch endpoint rather than_msearch. Dashboard panels will load individually, and search requests will terminate when users navigate away or update the query.