Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call failure reporter directly from Jenkinsfile #45551

Merged
merged 3 commits into from
Sep 13, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Sep 12, 2019

Fixes #45549

  • setup the trap to execute failure reporting only when not running in pipelines
  • execute node src/dev/failed_tests/cli from Jenkinsfile when all tests on a node are complete so that junit is crawled for errors once.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.3.2 v7.4.1 labels Sep 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elastic elastic deleted a comment from elasticmachine Sep 12, 2019
@spalger spalger force-pushed the fix/run-test-reporter-once branch from 10e7d90 to d608f8a Compare September 12, 2019 17:01
@elastic elastic deleted a comment from elasticmachine Sep 12, 2019
Jenkinsfile Outdated Show resolved Hide resolved
@elasticmachine

This comment has been minimized.

@spalger spalger force-pushed the fix/run-test-reporter-once branch from 133a6fb to 4cc8184 Compare September 12, 2019 19:47
@spalger spalger requested a review from a team as a code owner September 12, 2019 19:47
@elasticmachine

This comment has been minimized.

@spalger spalger force-pushed the fix/run-test-reporter-once branch from fbf3c49 to 82d440c Compare September 12, 2019 21:27
@elasticmachine

This comment has been minimized.

@spalger spalger force-pushed the fix/run-test-reporter-once branch from 678cebc to 3ddd924 Compare September 13, 2019 00:04
@elasticmachine

This comment has been minimized.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@brianseeders brianseeders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit ef5c520 into elastic:master Sep 13, 2019
@spalger spalger added the v6.8.4 label Sep 13, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 13, 2019
* Run failed_tests/cli once per node

* force failures for testing

* Revert "force failures for testing"

This reverts commit 3ddd924.
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 13, 2019
* Run failed_tests/cli once per node

* force failures for testing

* Revert "force failures for testing"

This reverts commit 3ddd924.
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 13, 2019
* Run failed_tests/cli once per node

* force failures for testing

* Revert "force failures for testing"

This reverts commit 3ddd924.
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 13, 2019
* Run failed_tests/cli once per node

* force failures for testing

* Revert "force failures for testing"

This reverts commit 3ddd924.

# Conflicts:
#	test/scripts/jenkins_firefox_smoke.sh
#	test/scripts/jenkins_visual_regression.sh
#	test/scripts/jenkins_xpack_firefox_smoke.sh
#	test/scripts/jenkins_xpack_visual_regression.sh
spalger pushed a commit that referenced this pull request Sep 13, 2019
* Run failed_tests/cli once per node

* force failures for testing

* Revert "force failures for testing"

This reverts commit 3ddd924.
spalger pushed a commit that referenced this pull request Sep 13, 2019
* Run failed_tests/cli once per node

* force failures for testing

* Revert "force failures for testing"

This reverts commit 3ddd924.
@spalger
Copy link
Contributor Author

spalger commented Sep 13, 2019

7.x/7.5: 65a3117
7.4: ead2468
7.3: d2792ed
6.8: c638263

@spalger spalger deleted the fix/run-test-reporter-once branch September 13, 2019 20:44
spalger pushed a commit that referenced this pull request Sep 13, 2019
* Run failed_tests/cli once per node

* force failures for testing

* Revert "force failures for testing"

This reverts commit 3ddd924.
spalger pushed a commit that referenced this pull request Sep 16, 2019
* Call failure reporter directly from Jenkinsfile (#45551)

* Run failed_tests/cli once per node

* force failures for testing

* Revert "force failures for testing"

This reverts commit 3ddd924.

# Conflicts:
#	test/scripts/jenkins_firefox_smoke.sh
#	test/scripts/jenkins_visual_regression.sh
#	test/scripts/jenkins_xpack_firefox_smoke.sh
#	test/scripts/jenkins_xpack_visual_regression.sh

* set NODE_OPTIONS for build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v6.8.4 v7.3.2 v7.4.1 v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pipelines] failure reporter is duplicating error reports
3 participants