Move legacy/server/index_patterns -> src/plugins/data/server #46537

sainthkh · 2019-09-24T23:27:08Z

Summary

Partially solves #44190.

Moved code from legacy/server/index_patterns to src/plugins/data/server.
Renamed IndexPatternsService to IndexPatternsFetcher. Because services are classes used by plugins that have setup(), start(), stop() methods. It can cause confusion.
Exposed IndexPatternsApiClient apis from IndexPatterns class. And used it in x-pack/beats_management.

Note.

eslint test will fail until no-restricted-paths bug is fixed in eslint no-restricted-path false positive: bug caused by dir names that start with "index". #46544.
As legacy code cannot access the code in src/plugins, the server-side _fields_for_wildcard request in rollup cannot be replaced with IndexPatternsFetcher yet.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~This was checked for cross-browser compatibility, including a check against IE11~~
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-09-24T23:27:10Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine · 2019-09-24T23:27:10Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine · 2019-09-25T12:33:21Z

Pinging @elastic/kibana-app-arch

ppisljar · 2019-09-25T12:33:56Z

jenkins, test this

elasticmachine · 2019-09-25T14:14:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

sainthkh · 2019-09-25T21:25:41Z

@ppisljar As I wrote in the note, there's a bug in eslint. So, it won't pass until #46544 is merged. The failed test in firefox is a flaky test.

I've run the test on my local for 5 times, it all passed.

…IndexPatternsService

…c/legacy api.

ppisljar · 2019-09-30T08:12:50Z

@elasticmachine merge upstream

lizozom · 2019-10-28T09:27:25Z

@elasticmachine merge upstream

...lugins/data/server/index_patterns/fetcher/lib/field_capabilities/field_caps_response.test.js

lizozom · 2019-10-31T15:36:16Z

Jenkins test this

lizozom · 2019-10-31T15:49:12Z

@sainthkh seems like there's another reference to IndexPatternsService in getKueryBarIndexPattern.ts that needs an update.

elasticmachine · 2019-10-31T16:19:18Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: e0bd02c

…ns-server-pt2

lizozom · 2019-11-04T12:55:57Z

@elasticmachine merge upstream

lizozom · 2019-11-05T15:10:37Z

Jenkins test this

lizozom · 2019-11-05T15:10:53Z

@elasticmachine merge upstream

lizozom · 2019-11-05T15:42:08Z

Jenkins, test this

elasticmachine · 2019-11-05T17:11:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 52b18c2

lizozom

Code changes look good.

lizozom

@sainthkh I'm still getting an error when navigating to APM application:

Could you add a test to catch this failure please?

sainthkh · 2019-11-06T00:25:42Z

@lizozom I found out that the bug has something to do with indexPatternsFetcher (because APM team decided to use it), but it wasn't introduced in this PR.

After following the history, I found out that it was introduced in 46304f0. If you check out that commit and a10cf38 (the commit right below that), 404 error doesn't show on a10, but on 463.

I guess it should be a separate issue and PR.

dgieselaar · 2019-11-06T12:08:02Z

@sainthkh I might be missing some context, but I cannot reproduce the 404 on master, if that is what you're suggesting. Can you?

sainthkh · 2019-11-06T13:00:22Z

Yes, I found 404 on master.

Check out that commit. + yarn kbn bootstrap
Start up kibana.
Set up flight sample. This step might be unrelated.
Turn on Chrome devtool console tab. Visit apm page.
404 error.

Env: ubuntu 18.04.

It's run from main kibana folder, not x-pack.

If you cannot reproduce it, please let me know. I'll check it out again tomorrow.

lizozom · 2019-11-06T21:42:34Z

@dgieselaar @sainthkh I can confirm that this bug happens on master.

lizozom

LGTM

dgieselaar · 2019-11-06T22:01:20Z

@lizozom strange, I've not been able to reproduce it on any of our environments. Do you have any settings that are out of the ordinary?

lizozom · 2019-11-06T22:04:09Z

@dgieselaar nope just fresh out of the box setup.
DM me.

dgieselaar

404 is likely because of lack of APM indices. Not a concern. Verified the branch against clusters with APM indices and all seems fine.

@ts-ignore

…#46537) Dismissed @elastic/kibana-app review of import changes. ts-ignored @ts-ignore * Moved files to plugins/data/server. * Renamed IndexPatternsService to IndexPatternsFetcher and created new IndexPatternsService * Set routerPath. * Fixed type error. * Changed beats_management _fields_for_wildcard request with data/public/legacy api. * Fixed changed paths. * Fixes crashes after merge. * Updated path for clarity. * Applied Plugin interface to service. * Fixed test failure caused by non camel case local variable name. * Fixed import to IndexPatternsService to IndexPatternsFetcher.

@ts-ignore

…#50081) Dismissed @elastic/kibana-app review of import changes. ts-ignored @ts-ignore * Moved files to plugins/data/server. * Renamed IndexPatternsService to IndexPatternsFetcher and created new IndexPatternsService * Set routerPath. * Fixed type error. * Changed beats_management _fields_for_wildcard request with data/public/legacy api. * Fixed changed paths. * Fixes crashes after merge. * Updated path for clarity. * Applied Plugin interface to service. * Fixed test failure caused by non camel case local variable name. * Fixed import to IndexPatternsService to IndexPatternsFetcher.

sainthkh mentioned this pull request Sep 25, 2019

eslint no-restricted-path false positive: bug caused by dir names that start with "index". #46544

Merged

3 tasks

sainthkh marked this pull request as ready for review September 25, 2019 03:46

sainthkh requested a review from a team September 25, 2019 03:46

sainthkh requested a review from a team as a code owner September 25, 2019 03:46

ppisljar added release_note:skip Skip the PR/issue when compiling release notes review Team:AppArch v7.5.0 v8.0.0 labels Sep 25, 2019

sainthkh added 7 commits September 27, 2019 11:41

Removed @ts-ignore

149f639

Moved files to plugins/data/server.

6e851ad

Renamed IndexPatternsService to IndexPatternsFetcher and created new …

062ce32

…IndexPatternsService

Set routerPath.

6a8444f

Fixed type error.

c683825

Changed beats_management _fields_for_wildcard request with data/publi…

738860e

…c/legacy api.

Fixed changed paths.

5315f22

sainthkh force-pushed the move-index-patterns-server-pt2 branch from d635764 to 5315f22 Compare September 27, 2019 02:51

Merge branch 'master' into move-index-patterns-server-pt2

9915148

streamich self-assigned this Oct 3, 2019

sainthkh added 2 commits October 5, 2019 06:25

Merge branch 'master' into move-index-patterns-server-pt2

4ae2907

Merge branch 'master' into move-index-patterns-server-pt2.

29273cf

lizozom reviewed Oct 28, 2019

View reviewed changes

...lugins/data/server/index_patterns/fetcher/lib/field_capabilities/field_caps_response.test.js Outdated Show resolved Hide resolved

sainthkh added 2 commits November 1, 2019 07:24

Fixed import to IndexPatternsService to IndexPatternsFetcher.

392e408

Merge remote-tracking branch 'upstream/master' into move-index-patter…

ec0f0f6

…ns-server-pt2

sainthkh requested a review from a team as a code owner October 31, 2019 22:25

sainthkh requested a review from lizozom October 31, 2019 22:25

Merge remote-tracking branch 'upstream/master' into move-index-patter…

f05a085

…ns-server-pt2

Merge branch 'master' into move-index-patterns-server-pt2

b1ad415

Merge branch 'master' into move-index-patterns-server-pt2

52b18c2

lizozom approved these changes Nov 5, 2019

View reviewed changes

lizozom suggested changes Nov 5, 2019

View reviewed changes

lizozom approved these changes Nov 6, 2019

View reviewed changes

dgieselaar approved these changes Nov 6, 2019

View reviewed changes

lizozom merged commit 3f130ba into elastic:master Nov 6, 2019

lizozom mentioned this pull request Nov 7, 2019

[7.x] Move legacy/server/index_patterns -> src/plugins/data/server (#46537) #50081

Merged

streamich mentioned this pull request Nov 11, 2019

Index Patterns 👉 New Platform #43438

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move legacy/server/index_patterns -> src/plugins/data/server #46537

Move legacy/server/index_patterns -> src/plugins/data/server #46537

sainthkh commented Sep 24, 2019 •

edited

Loading

elasticmachine commented Sep 24, 2019

elasticmachine commented Sep 24, 2019

elasticmachine commented Sep 25, 2019

ppisljar commented Sep 25, 2019

elasticmachine commented Sep 25, 2019

sainthkh commented Sep 25, 2019

ppisljar commented Sep 30, 2019

lizozom commented Oct 28, 2019

lizozom commented Oct 31, 2019

lizozom commented Oct 31, 2019 •

edited

Loading

elasticmachine commented Oct 31, 2019

lizozom commented Nov 4, 2019

lizozom commented Nov 5, 2019

lizozom commented Nov 5, 2019

lizozom commented Nov 5, 2019

elasticmachine commented Nov 5, 2019

lizozom left a comment •

edited

Loading

lizozom left a comment •

edited

Loading

sainthkh commented Nov 6, 2019 •

edited

Loading

dgieselaar commented Nov 6, 2019

sainthkh commented Nov 6, 2019 •

edited

Loading

lizozom commented Nov 6, 2019

lizozom left a comment

dgieselaar commented Nov 6, 2019

lizozom commented Nov 6, 2019

dgieselaar left a comment

Move legacy/server/index_patterns -> src/plugins/data/server #46537

Move legacy/server/index_patterns -> src/plugins/data/server #46537

Conversation

sainthkh commented Sep 24, 2019 • edited Loading

Summary

Note.

Checklist

For maintainers

elasticmachine commented Sep 24, 2019

elasticmachine commented Sep 24, 2019

elasticmachine commented Sep 25, 2019

ppisljar commented Sep 25, 2019

elasticmachine commented Sep 25, 2019

💔 Build Failed

sainthkh commented Sep 25, 2019

ppisljar commented Sep 30, 2019

lizozom commented Oct 28, 2019

lizozom commented Oct 31, 2019

lizozom commented Oct 31, 2019 • edited Loading

elasticmachine commented Oct 31, 2019

💔 Build Failed

lizozom commented Nov 4, 2019

lizozom commented Nov 5, 2019

lizozom commented Nov 5, 2019

lizozom commented Nov 5, 2019

elasticmachine commented Nov 5, 2019

💚 Build Succeeded

lizozom left a comment • edited Loading

Choose a reason for hiding this comment

lizozom left a comment • edited Loading

Choose a reason for hiding this comment

sainthkh commented Nov 6, 2019 • edited Loading

dgieselaar commented Nov 6, 2019

sainthkh commented Nov 6, 2019 • edited Loading

lizozom commented Nov 6, 2019

lizozom left a comment

Choose a reason for hiding this comment

dgieselaar commented Nov 6, 2019

lizozom commented Nov 6, 2019

dgieselaar left a comment

Choose a reason for hiding this comment

sainthkh commented Sep 24, 2019 •

edited

Loading

lizozom commented Oct 31, 2019 •

edited

Loading

lizozom left a comment •

edited

Loading

lizozom left a comment •

edited

Loading

sainthkh commented Nov 6, 2019 •

edited

Loading

sainthkh commented Nov 6, 2019 •

edited

Loading