FieldList IndexedArray removal #46653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
6 tasks
💔 Build Failed |
mattkime
force-pushed
the
field_list_not_indexed-array
branch
from
0fd7793 to
341d468
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
mattkime
force-pushed
the
field_list_not_indexed-array
branch
from
e22ca2d to
0fd0be8
Compare
|
@ppisljar I'm seeing a failed browser test relating to field chooser which involves a fair amount of angular code. I'm curious if you have any thoughts on it before I burn too much time on it. -- actually, it looks like kbnTableRow is where my attention should be. field chooser shows a similar error locally but i don’t see that on CI |
💔 Build Failed
|
💔 Build Failed
|
💔 Build Failed
|
mattkime
force-pushed
the
field_list_not_indexed-array
branch
from
5def33e to
5969420
Compare
💔 Build Failed
|
mattkime
force-pushed
the
field_list_not_indexed-array
branch
from
5969420 to
2dff992
Compare
💔 Build Failed |
💔 Build Failed |
mattkime
commented
Oct 10, 2019
| @@ -49,7 +49,7 @@ interface MappingObject { | |||
| } | |||
|
|
|||
| export interface StaticIndexPattern { | |||
| fields: FieldType[]; | |||
| fields: FieldType[] | FieldListInterface; | |||
There was a problem hiding this comment.
This is a sad compromise but I'm not sure what should be done about it. I think this is a case were refactoring with types in mind is more difficult than writing the code in the first place.
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers