Add types to Elasticsearch API calls #46668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
|
Pinging @elastic/kibana-platform |
💔 Build Failed |
joshdover
force-pushed
the
np/elasticsearch-types
branch
from
4dfe57b to
b22cd3a
Compare
💔 Build Failed |
joshdover
force-pushed
the
np/elasticsearch-types
branch
from
b22cd3a to
cb9adf7
Compare
💔 Build Failed |
7 tasks
kobelb
approved these changes
Sep 30, 2019
x-pack/plugins/security/server/authentication/providers/base.mock.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security/server/authentication/providers/base.mock.ts
Outdated
Show resolved
Hide resolved
joshdover
force-pushed
the
np/elasticsearch-types
branch
from
cb9adf7 to
de8b3ec
Compare
💔 Build Failed |
joshdover
force-pushed
the
np/elasticsearch-types
branch
2 times, most recently
from
befbe3f to
cddfcd0
Compare
💚 Build Succeeded |
rudolf
reviewed
Oct 2, 2019
joshdover
force-pushed
the
np/elasticsearch-types
branch
from
cddfcd0 to
51e6453
Compare
💚 Build Succeeded
|
joshdover
force-pushed
the
np/elasticsearch-types
branch
from
51e6453 to
0feef7f
Compare
💚 Build Succeeded
|
joshdover
force-pushed
the
np/elasticsearch-types
branch
from
0feef7f to
78d2194
Compare
💔 Build Failed |
|
retest |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
rudolf
approved these changes
Oct 7, 2019
|
@elasticmachine merge upstream |
💔 Build Failed |
💚 Build Succeeded |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Oct 7, 2019
joshdover
added a commit
that referenced
this pull request
Oct 7, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This copies the type information over from the legacy Elasticsearch plugin over to the core ElasticsearchService.
I had to copy these rather than re-use them due to the slightly different call signatures which I couldn't find a way to use mapped and conditional types to do a lookup on an overloaded callable interface. If anyone knows how to do that, let me know so I can avoid copying these.
cc @jasonrhodes
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers