[Vis: Default editor] Euification of Metric options tab #46930

sulemanof · 2019-09-30T14:04:33Z

Summary

A part of #38273.
EUIfication of the Options tab in the Metric visualization.

Applied changes:

disabling instead of removing Use color for and Color schema params;
removed inequality.js directives;
removed unused styles from sidebar.scss;

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

…ns/heatmap # Conflicts: # src/legacy/core_plugins/kbn_vislib_vis_types/public/components/common/number_input.tsx # src/legacy/core_plugins/kbn_vislib_vis_types/public/components/options/gauge/ranges_panel.tsx # src/legacy/core_plugins/kbn_vislib_vis_types/public/components/options/index.ts # src/legacy/core_plugins/kbn_vislib_vis_types/public/types.ts # src/legacy/ui/public/vis/vis_types/vislib_vis_type.js

…ns/heatmap # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

…ns/heatmap

…ns/heatmap # Conflicts: # src/legacy/core_plugins/kbn_vislib_vis_types/public/gauge.js # src/legacy/core_plugins/kbn_vislib_vis_types/public/goal.js # src/legacy/core_plugins/kbn_vislib_vis_types/public/heatmap.js # src/legacy/core_plugins/kbn_vislib_vis_types/public/pie.js # src/legacy/ui/public/vis/vis_types/vislib_vis_type.js

…ns/heatmap

…bana into EUIfication/options/heatmap

…ns/heatmap # Conflicts: # src/legacy/core_plugins/kbn_vislib_vis_types/public/controls/heatmap_options.html

…ns/heatmap # Conflicts: # src/legacy/core_plugins/kbn_vislib_vis_types/public/components/options/metrics_axes/label_options.tsx

…ns/metrics # Conflicts: # src/legacy/core_plugins/kbn_vislib_vis_types/public/components/common/index.ts # src/legacy/core_plugins/kbn_vislib_vis_types/public/gauge.d.ts # src/legacy/core_plugins/kbn_vislib_vis_types/public/gauge.js # src/legacy/core_plugins/kbn_vislib_vis_types/public/goal.js # src/legacy/core_plugins/kbn_vislib_vis_types/public/kbn_vislib_vis_types.js # src/legacy/core_plugins/kbn_vislib_vis_types/public/types.ts # src/legacy/core_plugins/kbn_vislib_vis_types/public/utils/collections.ts # src/legacy/core_plugins/kibana/public/discover/components/field_chooser/discover_index_pattern_directive.ts # src/legacy/ui/public/vis/editors/default/controls/ranges.tsx

elasticmachine · 2019-10-01T14:37:23Z

Pinging @elastic/kibana-app

elasticmachine · 2019-10-01T15:41:09Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

flash1293

Is it necessary to always show the value in the little popover if the input is also shown?

There is no legend in the metrics vis. Should we hide the help text here?

I'm not sure about the separation of the panels - why is "percentage mode" part of "Ranges"?
Suggestion:
First panel "Settings", contains "Percentage mode" and "Show title"
Second panel "Ranges", contains ranges and color settings (get rid of "Color options" heading, like in Gauge options panel)
Third panel "Style", contains just the font size

sulemanof · 2019-10-02T10:26:36Z

Thanks @flash1293 , your proposal really makes sense!
But I think we still need @cchaos approval to implement it in a such way!

snide · 2019-10-02T13:00:20Z

She's out on vacation so I'll fill in. I think @flash1293's suggestions make sense as well, so you're good from design. You can remove the tooltip by removing the showValue prop.

…ns/metrics

sulemanof · 2019-10-02T15:47:43Z

Hey @flash1293 and @snide !
Since I haven't had permissions to update the reviewers list (I can't even re-request review),
could you please take a look at this?

Thanks in advance!

elasticmachine · 2019-10-02T16:57:31Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-10-03T09:39:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a060a2e

sulemanof · 2019-10-07T08:26:42Z

@elasticmachine merge upstream

elasticmachine · 2019-10-07T09:29:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 02395e0

flash1293 · 2019-10-07T16:32:05Z

The changes look good to me.

Not sure whether we should tackle this in this PR, but IMHO there is a lot of UI around ranges that are not used as long as "None" is selected - it feels weird that you can select ranges and then do nothing with them - why selecting them in the first place?

My suggestion would be: There is a switch whether ranges are enabled or not - if it's set to off, none of the rest of the ranges UI is shown. If it is activated, the color is used for the labels initially and you can switch to background, but there is no setting for "none" (that's what the switch is for).

What do you think @sulemanof @snide ?

sulemanof · 2019-10-08T10:56:13Z

My suggestion would be: There is a switch whether ranges are enabled or not - if it's set to off, none of the rest of the ranges UI is shown. If it is activated, the color is used for the labels initially and you can switch to background, but there is no setting for "none" (that's what the switch is for).

Hey @flash1293 ! I suppose it could be a great solution, but I think it should be discussed with more people from kibana side. Would it be better to create a separate issue with discuss label and involve there others?

flash1293

@sulemanof you are probably right. Let's leave the decision to design whether we merge as is here and do this in a separate PR.

ryankeairns

Overall, the new form largely follows the old form although it does do away with the accordions. Along with that, there are several design small visual tweaks we would likely want to make here, so let's do a follow-up PR, regardless. I'll add an approval under the assumption that we'll do some more tidying up.

* EUIfication of metric_vis_options * Small fixes * Remove unused translations * Fix style comments * Remove unused styles

) * EUIfication of metric_vis_options * Small fixes * Remove unused translations * Fix style comments * Remove unused styles

… (elastic#47630) * EUIfication of metric_vis_options * Small fixes * Remove unused translations * Fix style comments * Remove unused styles

sulemanof and others added 28 commits September 16, 2019 14:19

EUIficate heatmap options

afe52aa

Move collections

aa5908f

Split labels in a panel

3aa727a

Remove angular templates

2aba289

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

bcf83b9

…ns/heatmap # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

Remove unused translations

5a38e6c

Fix functional tests

d22fe0e

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

58d8a59

…ns/heatmap

Fix validation

16afb0d

Fix UI details

f99b900

Compress color picker

345fc4c

Change highlight label

f123a4f

Improve types

9562d72

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

96edb3d

…ns/heatmap

Merge branch 'master' into EUIfication/options/heatmap

a3078b1

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

9ea7d72

…ns/heatmap

Fix comments

75c266b

Merge branch 'EUIfication/options/heatmap' of github.com:sulemanof/ki…

225e0b8

…bana into EUIfication/options/heatmap

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

7563c8b

…ns/heatmap # Conflicts: # src/legacy/core_plugins/kbn_vislib_vis_types/public/controls/heatmap_options.html

Replace headings h2 with h3

a7c1f96

Add functional tests

50eaf23

Create setCustomRangeByIndex

ea0d897

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

e119c16

…ns/heatmap # Conflicts: # src/legacy/core_plugins/kbn_vislib_vis_types/public/components/options/metrics_axes/label_options.tsx

EUIfication of metric_vis_options

540ddcd

Small fixes

662c940

sulemanof requested review from cchaos and maryia-lapata September 30, 2019 14:04

sulemanof added Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.5.0 v8.0.0 labels Oct 1, 2019

sulemanof added the release_note:skip Skip the PR/issue when compiling release notes label Oct 1, 2019

flash1293 self-requested a review October 1, 2019 15:04

flash1293 requested changes Oct 2, 2019

View reviewed changes

sulemanof added 2 commits October 2, 2019 16:38

Merge remote-tracking branch 'upstream/master' into EUIfiaction/optio…

5ab5a0e

…ns/metrics

Update the separation of the panels

717310f

Add style type

a060a2e

Merge branch 'master' into EUIfiaction/options/metrics

02395e0

flash1293 approved these changes Oct 8, 2019

View reviewed changes

ryankeairns approved these changes Oct 8, 2019

View reviewed changes

sulemanof merged commit b25df01 into elastic:master Oct 8, 2019

sulemanof deleted the EUIfiaction/options/metrics branch October 8, 2019 20:37

sulemanof mentioned this pull request Oct 8, 2019

[7.x] [Vis: Default editor] Euification of Metric options tab (#46930) #47630

Merged

sulemanof added a commit to sulemanof/kibana that referenced this pull request Oct 8, 2019

[Vis: Default editor] Euification of Metric options tab (elastic#46930)

f452b0c

* EUIfication of metric_vis_options * Small fixes * Remove unused translations * Fix style comments * Remove unused styles

sulemanof added a commit that referenced this pull request Oct 9, 2019

[Vis: Default editor] Euification of Metric options tab (#46930) (#47630

8d8eade

) * EUIfication of metric_vis_options * Small fixes * Remove unused translations * Fix style comments * Remove unused styles

sulemanof added the backported label Oct 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Vis: Default editor] Euification of Metric options tab #46930

[Vis: Default editor] Euification of Metric options tab #46930

sulemanof commented Sep 30, 2019 •

edited

Loading

elasticmachine commented Oct 1, 2019

elasticmachine commented Oct 1, 2019

flash1293 left a comment

sulemanof commented Oct 2, 2019

snide commented Oct 2, 2019

sulemanof commented Oct 2, 2019

elasticmachine commented Oct 2, 2019

elasticmachine commented Oct 3, 2019

sulemanof commented Oct 7, 2019

elasticmachine commented Oct 7, 2019

flash1293 commented Oct 7, 2019 •

edited

Loading

sulemanof commented Oct 8, 2019 •

edited

Loading

flash1293 left a comment

ryankeairns left a comment

[Vis: Default editor] Euification of Metric options tab #46930

[Vis: Default editor] Euification of Metric options tab #46930

Conversation

sulemanof commented Sep 30, 2019 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Oct 1, 2019

elasticmachine commented Oct 1, 2019

💚 Build Succeeded

flash1293 left a comment

Choose a reason for hiding this comment

sulemanof commented Oct 2, 2019

snide commented Oct 2, 2019

sulemanof commented Oct 2, 2019

elasticmachine commented Oct 2, 2019

💔 Build Failed

elasticmachine commented Oct 3, 2019

💚 Build Succeeded

sulemanof commented Oct 7, 2019

elasticmachine commented Oct 7, 2019

💚 Build Succeeded

flash1293 commented Oct 7, 2019 • edited Loading

sulemanof commented Oct 8, 2019 • edited Loading

flash1293 left a comment

Choose a reason for hiding this comment

ryankeairns left a comment

Choose a reason for hiding this comment

sulemanof commented Sep 30, 2019 •

edited

Loading

flash1293 commented Oct 7, 2019 •

edited

Loading

sulemanof commented Oct 8, 2019 •

edited

Loading