[APM] Add User agent to trace summary

[smith]

Fixes #47526

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 583deb8

[formgeist]

I think we can remove the subdued text here and make it consistent with how we display the trace % in the other part of the summary.

[formgeist]

Perhaps just "User agent & version" as the default message as that's what is expected to display.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: 41d4dd0

[smith]

@elasticmachine test this please

[formgeist]

LGTM 🎉

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 41d4dd0

[sorenlouv]

It might very well be different in the wild but in our test data 85% of all user agent labels are "Other":

[
  { "key": "Other", "doc_count": 10114314 },
  { "key": "Python Requests", "doc_count": 611706 },
  { "key": "curl", "doc_count": 561747 },
  { "key": "Java", "doc_count": 550257 },
  { "key": "HeadlessChrome", "doc_count": 17 }
]

Should we perhaps omit the user agent if it's "Other" (I expect the agents set it to other by default)?

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 41d4dd0

[formgeist]

Should we perhaps omit the user agent if it's "Other" (I expect the agents set it to other by default)?

Sure, I think it's reasonable to then omit when there's really nothing important to display in the summary. The actual information can still be found in metadata.

[sorenlouv]

The actual information can still be found in metadata.

Exactly my thinking. Only makes sense to surface this to the user if it's actually useful..

[smith]

@sqren @formgeist I'm not sure about hiding other. I grabbed a random transaction and saw this:

{
  "original": "Python/3.7 aiohttp/3.3.2",
  "name": "Other",
  "device": {
    "name": "Other"
  }
}

So perhaps we should keep other and put the original (which could be quite long) in the tooltip. Or maybe we could have the user agent link to the section in the metadata tab. Not sure about how to do it correctly, but I'm certain, that "Other" does not mean "No user agent reported."

[sorenlouv]

As I understood it, the initial approach was to display short, whitelisted name like "Firefox" (instead of "Mozilla/5.0 (X11; U; OpenBSD i386; en-US; rv:1.9.2.8) Gecko/20101230 Firefox/3.6.8"), "Chrome", "Safari" etc. And then in the tooltip show a slightly longer format including version.

If we couldn't match the user agent we would show "Other" and in the tooltip the original.

[smith]

As I understood it, the initial approach was to display short, whitelisted name like "Firefox" (instead of "Mozilla/5.0 (X11; U; OpenBSD i386; en-US; rv:1.9.2.8) Gecko/20101230 Firefox/3.6.8"), "Chrome", "Safari" etc. And then in the tooltip show a slightly longer format including version.

If we couldn't match the user agent we would show "Other" and in the tooltip the original.

So if it's not "Other" what do we show in the tooltip? Right now it shows "User agent and version" no matter what.

[formgeist]

I think we should display user.agent.name and user.agent.version like we do now. I think our Opbeans demo is pretty specific when it comes to using virtual user agents rather than a real web browser. We certainly can put it the raw string, but I find it incredibly hard to read. I reckon it's better to keep the field description in the tooltip because we no longer have labels in the summary.

[sorenlouv]

We can leave it as-is for now.

My main gripe with this is that despite our efforts to trim down and simplify the trace summary it's very easy to add "just another field". All the information is already available below in the metadata tab, so the fields we choose to highlight should be deliberately picked, and we should have a good story for what exactly the user wants to see. Maybe we have that here and I just misunderstood the use cases.