Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KQL support to alert and actions find API #47530

Merged
merged 4 commits into from
Oct 9, 2019

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Oct 7, 2019

Fixes #47525.

In this PR, I'm adding support for filter attribute when using the find API. This passes the attribute through to saved objects client find function where it now supports KQL (#41136).

@mikecote mikecote self-assigned this Oct 7, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikecote mikecote marked this pull request as ready for review October 8, 2019 01:10
@mikecote mikecote requested review from a team, bmcconaghy and pmuellr October 8, 2019 01:10
@mikecote mikecote added the review label Oct 8, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@mikecote mikecote merged commit b90600f into elastic:master Oct 9, 2019
mikecote added a commit to mikecote/kibana that referenced this pull request Oct 9, 2019
* Add KQL support to alert and actions find API

* Fix failing jest tests
mikecote added a commit that referenced this pull request Oct 9, 2019
* Add KQL support to alert and actions find API

* Fix failing jest tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes review v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add KQL support to the alert and actions find APIs.
4 participants