[APM] Documentation and alignment for impact column #47602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorelli25
reviewed
Oct 8, 2019
There was a problem hiding this comment.
Oh, nice! Since this is a tool tip, I don't think we need to explicitly say "Impact is..". What about something like this:
The most used and slowest endpoints in your service. Calculated by multiplying the relative average duration with the number of transactions per minute.
💚 Build Succeeded
|
formgeist
reviewed
Oct 8, 2019
Comment on lines
88
to
110
| name: ( | ||
| <EuiToolTip | ||
| content={i18n.translate( | ||
| 'xpack.apm.tracesTable.impactColumnDescription', | ||
| { | ||
| defaultMessage: | ||
| "The most used and slowest endpoints in your service. It's calculated by taking the relative average duration times the number of transactions per minute." | ||
| } | ||
| )} | ||
| > | ||
| <> | ||
| {i18n.translate('xpack.apm.tracesTable.impactColumnLabel', { | ||
| defaultMessage: 'Impact' | ||
| })} | ||
| </> | ||
| </EuiToolTip> | ||
| ), |
There was a problem hiding this comment.
EUI has an example in their tables docs where they add a small icon to indicate that there's some more information on the table name.
name: (
<EuiToolTip content="Their mascot is the Octokitty">
<span>
Github{' '}
<EuiIcon
size="s"
color="subdued"
type="questionInCircle"
className="eui-alignTop"
/>
</span>
</EuiToolTip>
)
Would we be able to add this in as a small visual enhancement too?
In the traces and transactions tables, left align the impact column heading and add a tooltip explaining what it means. Fixes elastic#44313 Fixes elastic#28559
smith
force-pushed
the
nls/44313/impact
branch
from
c21975f to
684e12d
Compare
💚 Build Succeeded |
smith
added a commit
to smith/kibana
that referenced
this pull request
Oct 10, 2019
In the traces and transactions tables, left align the impact column heading and add a tooltip explaining what it means. Fixes elastic#44313 Fixes elastic#28559
sorenlouv
added
the
apm:test-plan-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the traces and transactions tables, left align the impact column heading and add a tooltip explaining what it means.
Fixes #44313
Fixes #28559